Page MenuHomePhabricator
Differential D3842

[web] Push `changeThreadSettingsAction` down to `ThreadSettingsGeneralTab`
ClosedPublic
Actions

Authored by atul on Apr 25 2022, 12:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 5, 4:45 AM
Unknown Object (File)
Wed, Oct 30, 3:50 AM
Unknown Object (File)
Mon, Oct 28, 2:42 AM
Unknown Object (File)
Fri, Oct 11, 7:10 PM
Unknown Object (File)
Fri, Oct 11, 7:10 PM
Unknown Object (File)
Fri, Oct 11, 7:10 PM
Unknown Object (File)
Fri, Oct 11, 7:10 PM
Unknown Object (File)
Fri, Oct 11, 7:09 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
• karol

Details

Reviewers
• jacek
tomek
Commits
rCOMM924c7a1ad865: [web] Push `changeThreadSettingsAction` down to `ThreadSettingsGeneralTab`
Summary

Push down changeThreadSettingsAction (and accompanying state/functionality) to ThreadSettingsGeneralTab.

Also push down the "Save" button.

In the next diff will do the same for ThreadSettingsPrivacyTab

Depends on D3840

Test Plan
  1. Open ThreadSettingsModal
  2. Make some changes on the General tab
  3. Make sure that things continue to look/work as expected

Diff Detail

Repository
rCOMM Comm
Branch
clean (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Apr 25 2022, 12:39 PM
Herald added subscribers: • abosh, • karol, • adrian, ashoat. · View Herald TranscriptApr 25 2022, 12:39 PM
Harbormaster completed remote builds in B8529: Diff 11888.Apr 25 2022, 12:44 PM
atul requested review of this revision.Apr 25 2022, 12:44 PM
atul updated this revision to Diff 11889.Apr 25 2022, 12:45 PM

Fix button text

Harbormaster completed remote builds in B8530: Diff 11889.Apr 25 2022, 12:50 PM
atul added a child revision: D3844: [web] Push `changeThreadSettingsAction` down to `ThreadSettingsPrivacyTab`.Apr 25 2022, 4:03 PM
tomek accepted this revision.Apr 26 2022, 9:22 AM
tomek added inline comments.
web/modals/threads/thread-settings-general-tab.react.js
165–172 ↗(On Diff #11889)

It looks like you can create a new component that renders this button and contains changeThreadSettingsAction. This component could be used here and on privacy tab

This revision is now accepted and ready to land.Apr 26 2022, 9:22 AM
atul updated this revision to Diff 11955.Apr 26 2022, 10:49 AM

rebase

Harbormaster completed remote builds in B8576: Diff 11955.Apr 26 2022, 10:57 AM
atul updated this revision to Diff 12087.Apr 28 2022, 2:44 PM

rebase before landing

atul added inline comments.Apr 28 2022, 2:48 PM
web/modals/threads/thread-settings-general-tab.react.js
165–172 ↗(On Diff #11889)

Will give that a shot in a separate diff. There's definitely room here to cut the repetition

Harbormaster completed remote builds in B8679: Diff 12087.Apr 28 2022, 2:49 PM
Closed by commit rCOMM924c7a1ad865: [web] Push `changeThreadSettingsAction` down to `ThreadSettingsGeneralTab` (authored by atul). · Explain WhyApr 28 2022, 2:54 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM924c7a1ad865: [web] Push `changeThreadSettingsAction` down to `ThreadSettingsGeneralTab`.

Revision Contents
Changeset List

Diff 11955

View Options

web/modals/threads/thread-settings-general-tab.css

Loading...
View Options

web/modals/threads/thread-settings-general-tab.react.js

Loading...
View Options

web/modals/threads/thread-settings-modal.react.js

Loading...