Page MenuHomePhabricator

[web] Push `changeThreadSettingsAction` down to `ThreadSettingsPrivacyTab`
ClosedPublic

Authored by atul on Apr 25 2022, 4:03 PM.
Tags
None
Referenced Files
F3174733: D3844.id12090.diff
Thu, Nov 7, 5:51 PM
Unknown Object (File)
Tue, Nov 5, 4:45 AM
Unknown Object (File)
Wed, Oct 16, 8:41 AM
Unknown Object (File)
Fri, Oct 11, 7:11 PM
Unknown Object (File)
Fri, Oct 11, 7:11 PM
Unknown Object (File)
Fri, Oct 11, 7:11 PM
Unknown Object (File)
Fri, Oct 11, 7:11 PM
Unknown Object (File)
Thu, Oct 10, 2:12 AM

Details

Summary

Push down changeThreadSettingsAction (and accompanying state/functionality) to ThreadSettingsPrivacyTab.

Also push down the "Save" button.

In previous diff (D3842) did the same for ThreadSettingsGeneralTab... yes there's some repeated code but I think it's the best place to put it


Depends on D3842

Test Plan
  1. Open ThreadSettingsModal
  2. Make some changes on the Privacy tab
  3. Make sure that things continue to look/work as expected

Diff Detail

Repository
rCOMM Comm
Branch
clean (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul requested review of this revision.Apr 25 2022, 4:08 PM
This revision is now accepted and ready to land.Apr 26 2022, 9:24 AM