Page MenuHomePhabricator
Differential D3844

[web] Push `changeThreadSettingsAction` down to `ThreadSettingsPrivacyTab`
ClosedPublic
Actions

Authored by atul on Apr 25 2022, 4:03 PM.
Tags
None
Referenced Files
F3391093: D3844.diff
Sat, Nov 30, 2:15 AM
Unknown Object (File)
Wed, Nov 27, 12:27 AM
Unknown Object (File)
Tue, Nov 12, 2:36 PM
Unknown Object (File)
Sat, Nov 9, 10:48 PM
Unknown Object (File)
Sat, Nov 9, 2:55 PM
Unknown Object (File)
Sat, Nov 9, 7:51 AM
Unknown Object (File)
Thu, Nov 7, 5:51 PM
Unknown Object (File)
Tue, Nov 5, 4:45 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
• karol

Details

Reviewers
• jacek
tomek
Commits
rCOMM8e4158a5bd9a: [web] Push `changeThreadSettingsAction` down to `ThreadSettingsPrivacyTab`
Summary

Push down changeThreadSettingsAction (and accompanying state/functionality) to ThreadSettingsPrivacyTab.

Also push down the "Save" button.

In previous diff (D3842) did the same for ThreadSettingsGeneralTab... yes there's some repeated code but I think it's the best place to put it

Depends on D3842

Test Plan
  1. Open ThreadSettingsModal
  2. Make some changes on the Privacy tab
  3. Make sure that things continue to look/work as expected

Diff Detail

Repository
rCOMM Comm
Branch
clean (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Apr 25 2022, 4:03 PM
Herald added subscribers: • abosh, • karol, • adrian, ashoat. · View Herald TranscriptApr 25 2022, 4:03 PM
Harbormaster completed remote builds in B8532: Diff 11891.Apr 25 2022, 4:08 PM
atul requested review of this revision.Apr 25 2022, 4:08 PM
atul added a child revision: D3845: [web] Use new `Tabs.Container` instead of existing `Tabs` component.Apr 25 2022, 4:59 PM
tomek accepted this revision.Apr 26 2022, 9:24 AM
This revision is now accepted and ready to land.Apr 26 2022, 9:24 AM
atul updated this revision to Diff 11956.Apr 26 2022, 10:50 AM

rebase

Harbormaster completed remote builds in B8577: Diff 11956.Apr 26 2022, 10:59 AM
atul updated this revision to Diff 12089.Apr 28 2022, 2:56 PM

rebase before landing

Harbormaster completed remote builds in B8680: Diff 12089.Apr 28 2022, 3:01 PM
Closed by commit rCOMM8e4158a5bd9a: [web] Push `changeThreadSettingsAction` down to `ThreadSettingsPrivacyTab` (authored by atul). · Explain WhyApr 28 2022, 3:05 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM8e4158a5bd9a: [web] Push `changeThreadSettingsAction` down to `ThreadSettingsPrivacyTab`.

Revision Contents
Changeset List

Diff 11956

View Options

web/modals/threads/thread-settings-modal.react.js

Loading...
View Options

web/modals/threads/thread-settings-privacy-tab.css

Loading...
View Options

web/modals/threads/thread-settings-privacy-tab.react.js

Loading...