Page MenuHomePhabricator

Add protobuf with corrected cmake build
ClosedPublic

Authored by jon on Apr 27 2022, 2:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 2, 10:21 AM
Unknown Object (File)
Sat, Nov 2, 2:01 AM
Unknown Object (File)
Sat, Nov 2, 2:01 AM
Unknown Object (File)
Sat, Nov 2, 2:01 AM
Unknown Object (File)
Sat, Nov 2, 2:01 AM
Unknown Object (File)
Fri, Nov 1, 8:15 PM
Unknown Object (File)
Wed, Oct 16, 8:50 AM
Unknown Object (File)
Wed, Oct 16, 8:50 AM

Details

Summary

Unfortunately the protobuf 3.15 available in nix is using
an autotool build, which doesn't install the required protobuf-config.cmak
required by grpc to find the related package.

Upstreamed PR: https://github.com/NixOS/nixpkgs/pull/169497

Depends on D3793

Test Plan

nix build .#protobuf_3_15_cmake

Diff Detail

Repository
rCOMM Comm
Branch
joringer/add-nix-clean (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun requested changes to this revision.May 2 2022, 12:42 PM
varun added inline comments.
nix/cmake-install-path.patch
1–32 ↗(On Diff #12015)

should this file be in this diff?

This revision now requires changes to proceed.May 2 2022, 12:42 PM
nix/cmake-install-path.patch
1–32 ↗(On Diff #12015)

ah wait i see how it's used now

jon added inline comments.
nix/cmake-install-path.patch
1–32 ↗(On Diff #12015)

Yep, used in patches of the other file

jon marked an inline comment as done.
varun requested changes to this revision.May 11 2022, 11:00 AM

I see in your test plan that nix build .#protobuf_3_15_cmake works, but were you able to link the build output successfully? i.e. did you try building one of the services that depends on that package?

This revision now requires changes to proceed.May 11 2022, 11:00 AM

I don't think I was able to test it with nix develop and doing an impure workflow. Nix packaging is to come.

Remove cross compilation logic, likely unneeded

This revision is now accepted and ready to land.May 12 2022, 9:12 AM
This revision now requires review to proceed.May 12 2022, 9:12 AM
This revision is now accepted and ready to land.May 12 2022, 12:54 PM
This revision was automatically updated to reflect the committed changes.