Page MenuHomePhabricator
Differential D3838

[web] Add `accountPasswordInputRef` back to `ThreadSettingsDeleteTab`
ClosedPublic
Actions

Authored by atul on Apr 25 2022, 11:10 AM.
Tags
None
Referenced Files
F5092970: D3838.id11884.diff
Sun, Mar 30, 10:45 AM
F5086283: D3838.id12083.diff
Sat, Mar 29, 7:20 PM
Unknown Object (File)
Sat, Mar 29, 3:38 AM
Unknown Object (File)
Fri, Mar 28, 2:12 AM
Unknown Object (File)
Fri, Mar 28, 2:11 AM
Unknown Object (File)
Thu, Mar 27, 5:58 AM
Unknown Object (File)
Mon, Mar 24, 10:50 PM
Unknown Object (File)
Mon, Mar 17, 11:37 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
• karol

Details

Reviewers
• jacek
tomek
Commits
rCOMMc52992f6c39c: [web] Add `accountPasswordInputRef` back to `ThreadSettingsDeleteTab`
Summary

Bring back accountPasswordInputRef to ThreadSettingsDeleteTab using the React.useRef() hook.

We clear the input and focus() it on exception in deleteThreadAction.

Depends on D3837

Test Plan
  1. Open ThreadSettingsModal
  2. Navigate to Delete tab
  3. Enter gibberish for password
  4. Ensure that things continue to look/work as expected

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Apr 25 2022, 11:10 AM
Herald added subscribers: • abosh, • karol, • adrian, ashoat. · View Herald TranscriptApr 25 2022, 11:10 AM
atul added a comment.Apr 25 2022, 11:12 AM

(All the ThreadSettingsModal refactor-related TODOs have been resolved at this point)

atul published this revision for review.Apr 25 2022, 11:13 AM
Harbormaster completed remote builds in B8525: Diff 11884.Apr 25 2022, 11:15 AM
atul edited the summary of this revision. (Show Details)Apr 25 2022, 11:18 AM
atul added a parent revision: D3837: [web] Push "Delete thread" functionality down to `ThreadSettingsDeleteTab`.
atul removed a parent revision: D3832: [web] Add `nameInputRef` back to `ThreadSettingsGeneralTab`.
atul added a child revision: D3840: [web] Push `accountPassword` state and related functionality down to `ThreadSettingsDeleteTab`.Apr 25 2022, 11:38 AM
tomek accepted this revision.Apr 26 2022, 8:48 AM
This revision is now accepted and ready to land.Apr 26 2022, 8:48 AM
atul updated this revision to Diff 11953.Apr 26 2022, 10:45 AM

rebase

Harbormaster completed remote builds in B8574: Diff 11953.Apr 26 2022, 10:53 AM
atul updated this revision to Diff 12083.Apr 28 2022, 2:25 PM

rebase before landing

Harbormaster completed remote builds in B8677: Diff 12083.Apr 28 2022, 2:30 PM
Closed by commit rCOMMc52992f6c39c: [web] Add `accountPasswordInputRef` back to `ThreadSettingsDeleteTab` (authored by atul). · Explain WhyApr 28 2022, 2:31 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMc52992f6c39c: [web] Add `accountPasswordInputRef` back to `ThreadSettingsDeleteTab`.

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
6 lines

Diff 12084

View Options

web/modals/threads/thread-settings-delete-tab.react.js

Show First 20 Lines • Show All 103 Lines • ▼ Show 20 Lines const changeThreadSettingsAction = React.useCallback(async () => {
try { try {
setErrorMessage(''); setErrorMessage('');
return await callChangeThreadSettings({ return await callChangeThreadSettings({
threadID: threadInfo.id, threadID: threadInfo.id,
changes: queuedChanges, changes: queuedChanges,
}); });
} catch (e) { } catch (e) {
setErrorMessage('unknown_error'); setErrorMessage('unknown_error');
setQueuedChanges(Object.freeze({}));
throw e; throw e;
} finally {
setQueuedChanges(Object.freeze({}));
} }
}, [ }, [
callChangeThreadSettings, callChangeThreadSettings,
queuedChanges, queuedChanges,
setErrorMessage, setErrorMessage,
setQueuedChanges, setQueuedChanges,
threadInfo.id, threadInfo.id,
]); ]);
▲ Show 20 Lines • Show All 75 Lines • Show Last 20 Lines