Page MenuHomePhabricator
Differential D3840

[web] Push `accountPassword` state and related functionality down to `ThreadSettingsDeleteTab`
ClosedPublic
Actions

Authored by atul on Apr 25 2022, 11:38 AM.
Tags
None
Referenced Files
F5798124: D3840.diff
Tue, Apr 15, 6:51 PM
Unknown Object (File)
Sun, Apr 13, 3:45 PM
Unknown Object (File)
Tue, Apr 8, 11:32 PM
Unknown Object (File)
Tue, Apr 8, 6:31 PM
Unknown Object (File)
Tue, Apr 8, 6:17 PM
Unknown Object (File)
Tue, Apr 8, 6:15 PM
Unknown Object (File)
Tue, Apr 8, 5:51 AM
Unknown Object (File)
Tue, Apr 8, 5:22 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
• karol

Details

Reviewers
• jacek
tomek
Commits
rCOMMe9ae786729d6: [web] Push `accountPassword` state and related functionality down to…
Summary

We don't need to be holding onto this state in the parent component and passing it down to ThreadSettingsDeleteTab as a prop.

Depends on D3838

Test Plan

Careful reading, just drag and drop

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D3840 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Apr 25 2022, 11:38 AM
Herald added subscribers: • abosh, • karol, • adrian, ashoat. · View Herald TranscriptApr 25 2022, 11:38 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 25 2022, 11:38 AM
Harbormaster failed remote builds in B8527: Diff 11886!
Harbormaster completed remote builds in B8527: Diff 11886.Apr 25 2022, 11:43 AM
atul requested review of this revision.Apr 25 2022, 11:43 AM
atul added a child revision: D3842: [web] Push `changeThreadSettingsAction` down to `ThreadSettingsGeneralTab`.Apr 25 2022, 12:39 PM
tomek accepted this revision.Apr 26 2022, 8:54 AM
tomek added inline comments.
web/modals/threads/thread-settings-modal.react.js
151 ↗(On Diff #11886)

Please make sure that after failing to submit the changes, and opening delete tab, the input is cleared.

This revision is now accepted and ready to land.Apr 26 2022, 8:54 AM
atul updated this revision to Diff 11954.Apr 26 2022, 10:46 AM

rebase

Harbormaster completed remote builds in B8575: Diff 11954.Apr 26 2022, 10:52 AM
atul updated this revision to Diff 12085.Apr 28 2022, 2:33 PM

rebase before landing

Harbormaster completed remote builds in B8678: Diff 12085.Apr 28 2022, 2:37 PM
Closed by commit rCOMMe9ae786729d6: [web] Push `accountPassword` state and related functionality down to… (authored by atul). · Explain WhyApr 28 2022, 2:43 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMe9ae786729d6: [web] Push `accountPassword` state and related functionality down to….

Revision Contents
Changeset List

Diff 12085

View Options

web/modals/threads/thread-settings-delete-tab.react.js

Show All 25 Lines
import Modal from '../../modals/modal.react.js'; import Modal from '../../modals/modal.react.js';
import { updateNavInfoActionType } from '../../redux/action-types.js'; import { updateNavInfoActionType } from '../../redux/action-types.js';
import { useSelector } from '../../redux/redux-utils.js'; import { useSelector } from '../../redux/redux-utils.js';
import { nonThreadCalendarQuery } from '../../selectors/nav-selectors.js'; import { nonThreadCalendarQuery } from '../../selectors/nav-selectors.js';
const announcementStatements = [ const announcementStatements = [
{ {
statement: statement:
`This option sets the community's root channel to an ` + `This option sets the community’s root channel to an ` +
`announcement channel. Only admins and other admin-appointed ` + `announcement channel. Only admins and other admin-appointed ` +
`roles can send messages in an announcement channel.`, `roles can send messages in an announcement channel.`,
isStatementValid: true, isStatementValid: true,
styleStatementBasedOnValidity: false, styleStatementBasedOnValidity: false,
}, },
]; ];
const createNewCommunityLoadingStatusSelector = const createNewCommunityLoadingStatusSelector =
▲ Show 20 Lines • Show All 123 Lines • ▼ Show 20 Lines >
type="text" type="text"
value={pendingCommunityName} value={pendingCommunityName}
placeholder="Community Name" placeholder="Community Name"
onChange={onChangePendingCommunityName} onChange={onChangePendingCommunityName}
/> />
</div> </div>
</div> </div>
<div className={css.formNotice}> <div className={css.formNotice}>
You may edit your community&apos;s image and name later. You may edit your community&rsquo;s image and name later.
</div> </div>
<hr /> <hr />
<div className={css.optionalSettingsContainer}> <div className={css.optionalSettingsContainer}>
<div className={css.optionalSettingsLabel}>Optional settings</div> <div className={css.optionalSettingsLabel}>Optional settings</div>
<EnumSettingsOption <EnumSettingsOption
selected={announcementSetting} selected={announcementSetting}
onSelect={onAnnouncementSelected} onSelect={onAnnouncementSelected}
icon={megaphoneIcon} icon={megaphoneIcon}
Show All 26 Lines
View Options

web/modals/threads/thread-settings-modal.react.js

Show All 25 Lines
import Modal from '../../modals/modal.react.js'; import Modal from '../../modals/modal.react.js';
import { updateNavInfoActionType } from '../../redux/action-types.js'; import { updateNavInfoActionType } from '../../redux/action-types.js';
import { useSelector } from '../../redux/redux-utils.js'; import { useSelector } from '../../redux/redux-utils.js';
import { nonThreadCalendarQuery } from '../../selectors/nav-selectors.js'; import { nonThreadCalendarQuery } from '../../selectors/nav-selectors.js';
const announcementStatements = [ const announcementStatements = [
{ {
statement: statement:
`This option sets the community&apos;s root channel to an ` + `This option sets the community’s root channel to an ` +
`announcement channel. Only admins and other admin-appointed ` + `announcement channel. Only admins and other admin-appointed ` +
`roles can send messages in an announcement channel.`, `roles can send messages in an announcement channel.`,
isStatementValid: true, isStatementValid: true,
styleStatementBasedOnValidity: false, styleStatementBasedOnValidity: false,
}, },
]; ];
const createNewCommunityLoadingStatusSelector = const createNewCommunityLoadingStatusSelector =
▲ Show 20 Lines • Show All 123 Lines • ▼ Show 20 Lines >
type="text" type="text"
value={pendingCommunityName} value={pendingCommunityName}
placeholder="Community Name" placeholder="Community Name"
onChange={onChangePendingCommunityName} onChange={onChangePendingCommunityName}
/> />
</div> </div>
</div> </div>
<div className={css.formNotice}> <div className={css.formNotice}>
You may edit your community&apos;s image and name later. You may edit your community&rsquo;s image and name later.
</div> </div>
<hr /> <hr />
<div className={css.optionalSettingsContainer}> <div className={css.optionalSettingsContainer}>
<div className={css.optionalSettingsLabel}>Optional settings</div> <div className={css.optionalSettingsLabel}>Optional settings</div>
<EnumSettingsOption <EnumSettingsOption
selected={announcementSetting} selected={announcementSetting}
onSelect={onAnnouncementSelected} onSelect={onAnnouncementSelected}
icon={megaphoneIcon} icon={megaphoneIcon}
Show All 26 Lines