Page MenuHomePhabricator

[web] Push `accountPassword` state and related functionality down to `ThreadSettingsDeleteTab`
ClosedPublic

Authored by atul on Apr 25 2022, 11:38 AM.
Tags
None
Referenced Files
F3175267: D3840.diff
Thu, Nov 7, 7:53 PM
Unknown Object (File)
Tue, Nov 5, 4:45 AM
Unknown Object (File)
Wed, Oct 16, 8:41 AM
Unknown Object (File)
Fri, Oct 11, 7:09 PM
Unknown Object (File)
Fri, Oct 11, 7:09 PM
Unknown Object (File)
Fri, Oct 11, 7:09 PM
Unknown Object (File)
Fri, Oct 11, 7:08 PM
Unknown Object (File)
Thu, Oct 10, 7:55 AM

Details

Summary

We don't need to be holding onto this state in the parent component and passing it down to ThreadSettingsDeleteTab as a prop.


Depends on D3838

Test Plan

Careful reading, just drag and drop

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D3840 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 25 2022, 11:38 AM
Harbormaster failed remote builds in B8527: Diff 11886!
atul requested review of this revision.Apr 25 2022, 11:43 AM
tomek added inline comments.
web/modals/threads/thread-settings-modal.react.js
151 ↗(On Diff #11886)

Please make sure that after failing to submit the changes, and opening delete tab, the input is cleared.

This revision is now accepted and ready to land.Apr 26 2022, 8:54 AM