Push down changeThreadSettingsAction (and accompanying state/functionality) to ThreadSettingsGeneralTab.
Also push down the "Save" button.
In the next diff will do the same for ThreadSettingsPrivacyTab
Depends on D3840
Paths
| Differential D3842 Authored by atul on Apr 25 2022, 12:39 PM.
Tags None Referenced Files
Details Summary Push down changeThreadSettingsAction (and accompanying state/functionality) to ThreadSettingsGeneralTab. Also push down the "Save" button. In the next diff will do the same for ThreadSettingsPrivacyTab Depends on D3840 Test Plan
Diff Detail
Event TimelineHerald added subscribers: • abosh, • karol, • adrian, ashoat. · View Herald TranscriptApr 25 2022, 12:39 PM2022-04-25 12:39:47 (UTC-7) Harbormaster completed remote builds in B8529: Diff 11888.Apr 25 2022, 12:44 PM2022-04-25 12:44:39 (UTC-7) Harbormaster completed remote builds in B8530: Diff 11889.Apr 25 2022, 12:50 PM2022-04-25 12:50:43 (UTC-7) This revision is now accepted and ready to land.Apr 26 2022, 9:22 AM2022-04-26 09:22:14 (UTC-7) Harbormaster completed remote builds in B8576: Diff 11955.Apr 26 2022, 10:57 AM2022-04-26 10:57:03 (UTC-7)
Harbormaster completed remote builds in B8679: Diff 12087.Apr 28 2022, 2:49 PM2022-04-28 14:49:30 (UTC-7) Closed by commit rCOMM924c7a1ad865: [web] Push `changeThreadSettingsAction` down to `ThreadSettingsGeneralTab` (authored by atul). · Explain WhyApr 28 2022, 2:54 PM2022-04-28 14:54:38 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 12087 web/modals/threads/thread-settings-general-tab.css
web/modals/threads/thread-settings-general-tab.react.js
web/modals/threads/thread-settings-modal.react.js
|