Paths

Table of Contentst

[web] Push `<form>` tag down from `ThreadSettingsModal` to child "Tab" components
ClosedPublic
Actions

Authored by atul on May 5 2022, 1:39 PM.

Details

Reviewers

ashoat
tomek

Commits

rCOMMcb2b044b0ed6: [web] Push `<form>` tag down from `ThreadSettingsModal` to child "Tab"…

Summary

Addresses feedback from @palys-swm in a previous stack. Makes ThreadSettingsModal cleaner.

Test Plan

Things continue to look/work as expected:

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.May 5 2022, 1:39 PM

Herald added subscribers: • abosh, • karol, • adrian. · View Herald TranscriptMay 5 2022, 1:39 PM

Harbormaster completed remote builds in B8809: Diff 12275.May 5 2022, 1:44 PM

atul requested review of this revision.May 5 2022, 1:44 PM

atul added a child revision: D3929: [web] Remove unused styles from `thread-settings-modal.css`.May 5 2022, 2:09 PM

atul edited the test plan for this revision. (Show Details)May 5 2022, 3:16 PM

ashoat accepted this revision.May 5 2022, 3:58 PM

This revision is now accepted and ready to land.May 5 2022, 3:58 PM

Closed by commit rCOMMcb2b044b0ed6: [web] Push `<form>` tag down from `ThreadSettingsModal` to child "Tab"…. · Explain WhyMay 5 2022, 4:16 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMcb2b044b0ed6: [web] Push `<form>` tag down from `ThreadSettingsModal` to child "Tab"….

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

thread-settings-delete-tab.react.js

4 lines

thread-settings-general-tab.react.js

4 lines

thread-settings-modal.react.js

13 lines

thread-settings-privacy-tab.react.js

110 lines

Diff 12294

View Options

web/modals/threads/thread-settings-delete-tab.react.js

View Options

web/modals/threads/thread-settings-general-tab.react.js

View Options

web/modals/threads/thread-settings-modal.react.js

View Options

web/modals/threads/thread-settings-privacy-tab.react.js

[web] Push `<form>` tag down from `ThreadSettingsModal` to child "Tab" componentsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 12294

web/modals/threads/thread-settings-delete-tab.react.js

web/modals/threads/thread-settings-general-tab.react.js

web/modals/threads/thread-settings-modal.react.js

web/modals/threads/thread-settings-privacy-tab.react.js

[web] Push `<form>` tag down from `ThreadSettingsModal` to child "Tab" components
ClosedPublic
Actions

Revision Contents
Changeset List