Paths

Table of Contentst

Differential D4136

[services] Remove `export` from the `package.json` scripts
ClosedPublic
Actions

Authored by • max on May 26 2022, 6:05 AM.

Tags

None

Referenced Files

	F3380761: D4136.id13145.diff
	Thu, Nov 28, 1:57 AM

	Unknown Object (File)
	Fri, Nov 22, 6:15 PM

	Unknown Object (File)
	Thu, Nov 7, 9:19 AM

	Unknown Object (File)
	Oct 28 2024, 3:03 AM

	Unknown Object (File)
	Oct 28 2024, 3:02 AM

	Unknown Object (File)
	Oct 28 2024, 3:01 AM

	Unknown Object (File)
	Oct 28 2024, 2:51 AM

	Unknown Object (File)
	Oct 16 2024, 8:43 AM

Subscribers

Details

Reviewers

• karol
tomek
ashoat

Commits

rCOMMa09cc35b28fd: [services] Remove `export` from the `package.json` scripts

Summary

At the D4126 @ashoat made a suggestion that we don't need to export in the services package.json file for the environment variable export to the bash scripts. We can remove it from the package.json scripts section.

Linear task: ENG-1197

Test Plan

Running yarn run-backup-service-dev-mode successfully passed COMM_SERVICES_DEV_MODE=1 environment variable to the binary inside the Docker container and executed the dev-mode.

Diff Detail

Repository

Branch

remove-exports-from-packagejson

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.May 26 2022, 6:05 AM

• max held this revision as a draft.

Herald added subscribers: • abosh, • karol, atul and 2 others. · View Herald TranscriptMay 26 2022, 6:05 AM

• max published this revision for review.May 26 2022, 6:08 AM

• max edited the summary of this revision. (Show Details)

• max edited the test plan for this revision. (Show Details)

• max added reviewers: • karol, tomek.

Harbormaster completed remote builds in B9491: Diff 13145.May 26 2022, 6:12 AM

• max mentioned this in D4126: [services] Tunnelbroker - Add yarn scripts for dev-mode.May 26 2022, 6:13 AM

• max added a child revision: D4126: [services] Tunnelbroker - Add yarn scripts for dev-mode.May 26 2022, 6:14 AM

• karol accepted this revision.May 26 2022, 6:22 AM

ashoat accepted this revision.May 26 2022, 7:58 AM

tomek accepted this revision.May 27 2022, 2:21 AM

This revision is now accepted and ready to land.May 27 2022, 2:21 AM

Closed by commit rCOMMa09cc35b28fd: [services] Remove `export` from the `package.json` scripts (authored by • max). · Explain WhyMay 29 2022, 11:26 PM

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMMa09cc35b28fd: [services] Remove `export` from the `package.json` scripts.

Revision Contents
Changeset List

Path

Size

services/

14 lines

Diff 13145

services/package.json

Loading...