[services] Tunnelbroker - Change `ConfigManager.load()` to use config file path as a parameter
ClosedPublic
Actions

Authored by • max on May 25 2022, 1:11 PM.

Details

Reviewers

• karol
tomek

Commits

rCOMMbf09f40e34be: [services] Tunnelbroker - Change `ConfigManager.load()` to use config file path…

Summary

To change the config file path for dev-mode introducing changes to the ConfigManager.load() method to use config file path as a parameter instead of the config file path inside the method itself.

Linear task: ENG-1101

Test Plan

Run yarn run-tunnelbroker-service service successfuly built and load the default config file.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• max created this revision.May 25 2022, 1:11 PM

• max held this revision as a draft.

Herald added subscribers: • abosh, • karol, atul and 3 others. · View Herald TranscriptMay 25 2022, 1:11 PM

Harbormaster completed remote builds in B9476: Diff 13130.May 25 2022, 1:16 PM

• max added parent revisions: D4126: [services] Tunnelbroker - Add yarn scripts for dev-mode, D4127: [services] Tunnelbroker - Add config ini file for dev-mode.May 25 2022, 1:56 PM

• max published this revision for review.May 25 2022, 1:59 PM

• max edited the summary of this revision. (Show Details)

• max added reviewers: • karol, tomek.

• max removed a parent revision: D4126: [services] Tunnelbroker - Add yarn scripts for dev-mode.

• max added a child revision: D4130: [services] Tunnelbroker - Load dev-mode config file on start.

Stack postition update.

• max edited parent revisions, added: D4131: [services] Tunnelbroker - Dev-mode environment variables in Docker; removed: D4127: [services] Tunnelbroker - Add config ini file for dev-mode.May 26 2022, 1:17 AM

Harbormaster completed remote builds in B9481: Diff 13135.May 26 2022, 1:24 AM

tomek accepted this revision.May 26 2022, 3:52 AM

tomek added 1 blocking reviewer(s): • karol.

• karol accepted this revision.May 26 2022, 5:58 AM

• karol added inline comments.

services/tunnelbroker/src/Tools/ConfigManager.cpp
2 ↗	(On Diff #13135)	is this still needed?

This revision is now accepted and ready to land.May 26 2022, 5:58 AM

• max marked an inline comment as done.May 30 2022, 6:32 AM

• max added inline comments.

services/tunnelbroker/src/Tools/ConfigManager.cpp
2 ↗	(On Diff #13135)	is this still needed? Yes, we are heavily using the default values from `Constants.h` as a default value if no value in the config file was provided. For example, we are using the value from the constant at line 56 (`AMQP_FANOUT_EXCHANGE_NAME`).