Add libiconv for identity service build
ClosedPublic
Actions

Authored by • jon on Jun 1 2022, 12:41 PM.

Tags

None

Referenced Files

	F3361422: D4181.diff
	Sun, Nov 24, 5:21 PM

	Unknown Object (File)
	Fri, Nov 22, 1:47 AM

	Unknown Object (File)
	Fri, Nov 22, 1:41 AM

	Unknown Object (File)
	Thu, Nov 14, 6:08 AM

	Unknown Object (File)
	Tue, Nov 12, 12:19 PM

	Unknown Object (File)
	Mon, Nov 11, 4:26 AM

	Unknown Object (File)
	Sun, Nov 10, 11:47 AM

	Unknown Object (File)
	Sun, Nov 10, 1:37 AM

Subscribers

Details

Reviewers

varun
ashoat

Commits

rCOMM9489d10ded21: Add libiconv for identity service build

Summary

Crate was added which links against it.

Depends on D3902

Test Plan

nix develop && cd services/identity && cargo build && echo Success

Diff Detail

Repository

rCOMM Comm

Branch

joringer/fix-nix-identity

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Jun 1 2022, 12:41 PM

Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJun 1 2022, 12:41 PM

Harbormaster completed remote builds in B9579: Diff 13289.Jun 1 2022, 12:49 PM

• jon requested review of this revision.Jun 1 2022, 12:49 PM

varun accepted this revision.Jun 1 2022, 12:52 PM

This revision is now accepted and ready to land.Jun 1 2022, 12:52 PM

Herald added a reviewer: ashoat. · View Herald TranscriptJun 1 2022, 12:52 PM

This revision now requires review to proceed.Jun 1 2022, 12:52 PM

ashoat accepted this revision.Jun 1 2022, 2:18 PM

This revision is now accepted and ready to land.Jun 1 2022, 2:18 PM

Closed by commit rCOMM9489d10ded21: Add libiconv for identity service build (authored by • jon). · Explain WhyJun 15 2022, 3:49 PM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMM9489d10ded21: Add libiconv for identity service build.

• jon added a child revision: D4292: [Nix] Update nix flake lock, fix arcanist.Jun 19 2022, 11:15 AM

Revision Contents
Changeset List

Path

Size

nix/

dev-shell.nix

2 lines

Diff 13289

View Options

Add libiconv for identity service buildClosedPublicActions