Page MenuHomePhabricator
Differential D4181

Add libiconv for identity service build
ClosedPublic
Actions

Authored by • jon on Jun 1 2022, 12:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 30, 1:08 PM
Unknown Object (File)
Thu, Mar 27, 6:20 AM
Unknown Object (File)
Mon, Mar 24, 12:53 AM
Unknown Object (File)
Mon, Mar 24, 12:53 AM
Unknown Object (File)
Mon, Mar 24, 12:53 AM
Unknown Object (File)
Fri, Mar 21, 1:02 AM
Unknown Object (File)
Thu, Mar 13, 11:29 AM
Unknown Object (File)
Thu, Mar 13, 11:28 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek
varun

Details

Reviewers
varun
ashoat
Commits
rCOMM9489d10ded21: Add libiconv for identity service build
Summary

Crate was added which links against it.

Depends on D3902

Test Plan
nix develop && cd services/identity && cargo build && echo Success

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
nix/
2 lines

Diff 13535

View Options

nix/dev-shell.nix

Show First 20 Lines • Show All 98 Lines • ▼ Show 20 Linesconst bindCallKeyserverEndpointSelector = createSelector(
( (
dispatch: Dispatch, dispatch: Dispatch,
currentUserInfo: ?CurrentUserInfo, currentUserInfo: ?CurrentUserInfo,
keyserverInfos: { +[keyserverID: string]: KeyserverInfo }, keyserverInfos: { +[keyserverID: string]: KeyserverInfo },
) => { ) => {
return _memoize( return _memoize(
<Args: $ReadOnlyArray<mixed>, Return>( <Args: $ReadOnlyArray<mixed>, Return>(
keyserverCall: KeyserverCall<Args, Return>, keyserverCall: KeyserverCall<Args, Return>,
): ((...Args) => Promise<Return>) => { ): ((...Args) => Promise<Return>) => {
michalUnsubmitted
Not Done
Inline Actions

I meant that this Return is wrong, because in case of fanout it returns [Return]

michal: I meant that this `Return` is wrong, because in case of `fanout` it returns `[Return]`
const callKeyserverEndpoint = ( const callKeyserverEndpoint = (
endpoint: Endpoint, endpoint: Endpoint,
data: Object, data: Object,
args: Args, args: Args,
options?: ?CallServerEndpointOptions, options?: ?CallServerEndpointOptions,
) => { ) => {
// TODO const bindCallKeyserverEndpoint = (keyserverID: string) => {
if (keyserverCall.config.keyserverSelection === 'fanout') {
return Promise.resolve(undefined);
}
const keyserverID = keyserverCall.config.keyserverIDExtractor(
...args,
);
const { const {
cookie, cookie,
urlPrefix, urlPrefix,
sessionID, sessionID,
connection, connection,
lastCommunicatedPlatformDetails, lastCommunicatedPlatformDetails,
} = keyserverInfos[keyserverID]; } = keyserverInfos[keyserverID];
const boundCallServerEndpoint = createBoundServerCallsSelector( const boundCallServerEndpoint = createBoundServerCallsSelector(
keyserverID, keyserverID,
)({ )({
dispatch, dispatch,
currentUserInfo, currentUserInfo,
cookie, cookie,
urlPrefix, urlPrefix,
sessionID, sessionID,
connectionStatus: connection.status, connectionStatus: connection.status,
lastCommunicatedPlatformDetails, lastCommunicatedPlatformDetails,
}); });
return boundCallServerEndpoint(endpoint, data, options); return boundCallServerEndpoint(endpoint, data, options);
}; };
if (keyserverCall.config.keyserverSelection === 'fanout') {
const promises = [];
for (const keyserverID in keyserverInfos) {
promises.push(bindCallKeyserverEndpoint(keyserverID));
}
return Promise.all(promises);
}
const keyserverID = keyserverCall.config.keyserverIDExtractor(
...args,
);
return bindCallKeyserverEndpoint(keyserverID);
};
return keyserverCall.actionFunc(callKeyserverEndpoint); return keyserverCall.actionFunc(callKeyserverEndpoint);
}, },
); );
}, },
); );
function useKeyserverCall<Args: $ReadOnlyArray<mixed>, Return>( function useKeyserverCall<Args: $ReadOnlyArray<mixed>, Return>(
Show All 21 Lines