Paths

Table of Contentst

-
native/cpp/CommonCpp/grpc/
-
cpp/
-
CommonCpp/
-
grpc/
-
CMakeLists.txt
-
Client.h
-
Client.cpp
-
ClientGetReadReactor.h
-
ClientGetReadReactor.cpp
-
GRPCStreamHostObject.cpp
-
_generated/
-
.clang-format
-
blob.grpc.pb.h
-
blob.grpc.pb.cc
-
blob.pb.h
-
blob.pb.cc
-
tunnelbroker.grpc.pb.h
-
tunnelbroker.grpc.pb.cc
-
tunnelbroker.pb.h
-
tunnelbroker.pb.cc
-
cmake/
-
FindGRPCComm.cmake
-
nix/
-
comm-grpc.nix
-
overlay.nix

[Services] Generate Protobuf files with CMake
AbandonedPublicDraft
Actions

Authored by • jon on Jul 3 2022, 8:51 AM.

Details

Reviewers

ashoat
varun
• max
• karol

Summary

This is a more opinionated version of D3867,
in which CMake automatically generates the files.

Depends on D4294

Test Plan

nix build .#comm-grpc

cd native/cpp/CommonCpp/grpc/ && mkdir build && cd build && cmake .. && make

Diff Detail

Repository

rCOMM Comm

Branch

joringer/cmake-generated-protos

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Jul 3 2022, 8:51 AM

Herald added subscribers: • abosh, atul, • adrian, tomek. · View Herald TranscriptJul 3 2022, 8:51 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 3 2022, 9:02 AM

Harbormaster failed remote builds in B10218: Diff 14105!

generated files will be missing @generated, thus not able to be diff'd in current workflow without manual intervention.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

grpc/

CMakeLists.txt

103 lines

Client.h

4 lines

Client.cpp

4 lines

ClientGetReadReactor.h

6 lines

ClientGetReadReactor.cpp

2 lines

GRPCStreamHostObject.cpp

6 lines

_generated/

tunnelbroker.grpc.pb.h

tunnelbroker.grpc.pb.cc

tunnelbroker.pb.h

tunnelbroker.pb.cc

cmake/

FindGRPCComm.cmake

50 lines

nix/

comm-grpc.nix

27 lines

overlay.nix

2 lines

Diff 14105

View Options

native/cpp/CommonCpp/grpc/CMakeLists.txt

View Options

native/cpp/CommonCpp/grpc/Client.h

View Options

native/cpp/CommonCpp/grpc/Client.cpp

View Options

native/cpp/CommonCpp/grpc/ClientGetReadReactor.h

View Options

native/cpp/CommonCpp/grpc/ClientGetReadReactor.cpp

View Options

native/cpp/CommonCpp/grpc/GRPCStreamHostObject.cpp

View Options

native/cpp/CommonCpp/grpc/_generated/.clang-format

View Options

native/cpp/CommonCpp/grpc/_generated/blob.grpc.pb.h

View Options

native/cpp/CommonCpp/grpc/_generated/blob.grpc.pb.cc

View Options

native/cpp/CommonCpp/grpc/_generated/blob.pb.h

View Options

native/cpp/CommonCpp/grpc/_generated/blob.pb.cc

View Options

native/cpp/CommonCpp/grpc/_generated/tunnelbroker.grpc.pb.h

View Options

native/cpp/CommonCpp/grpc/_generated/tunnelbroker.grpc.pb.cc

View Options

native/cpp/CommonCpp/grpc/_generated/tunnelbroker.pb.h

View Options

native/cpp/CommonCpp/grpc/_generated/tunnelbroker.pb.cc

View Options

native/cpp/CommonCpp/grpc/cmake/FindGRPCComm.cmake

View Options

nix/comm-grpc.nix

View Options

[Services] Generate Protobuf files with CMakeAbandonedPublicDraftActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 14105

native/cpp/CommonCpp/grpc/CMakeLists.txt

native/cpp/CommonCpp/grpc/Client.h

native/cpp/CommonCpp/grpc/Client.cpp

native/cpp/CommonCpp/grpc/ClientGetReadReactor.h

native/cpp/CommonCpp/grpc/ClientGetReadReactor.cpp

native/cpp/CommonCpp/grpc/GRPCStreamHostObject.cpp

native/cpp/CommonCpp/grpc/_generated/.clang-format

native/cpp/CommonCpp/grpc/_generated/blob.grpc.pb.h

native/cpp/CommonCpp/grpc/_generated/blob.grpc.pb.cc

native/cpp/CommonCpp/grpc/_generated/blob.pb.h

native/cpp/CommonCpp/grpc/_generated/blob.pb.cc

native/cpp/CommonCpp/grpc/_generated/tunnelbroker.grpc.pb.h

native/cpp/CommonCpp/grpc/_generated/tunnelbroker.grpc.pb.cc

native/cpp/CommonCpp/grpc/_generated/tunnelbroker.pb.h

native/cpp/CommonCpp/grpc/_generated/tunnelbroker.pb.cc

native/cpp/CommonCpp/grpc/cmake/FindGRPCComm.cmake

nix/comm-grpc.nix

nix/overlay.nix

[Services] Generate Protobuf files with CMake
AbandonedPublicDraft
Actions

Revision Contents
Changeset List