Paths

Table of Contentst

Differential D4497

[services] Tunnelbroker - Install Rust and Corrosion in Dockerfile
ClosedPublic
Actions

Authored by • max on Jul 11 2022, 4:34 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 2, 10:36 AM

	Unknown Object (File)
	Sat, Nov 2, 10:36 AM

	Unknown Object (File)
	Sat, Nov 2, 10:35 AM

	Unknown Object (File)
	Sat, Nov 2, 10:33 AM

	Unknown Object (File)
	Oct 14 2024, 8:03 PM

	Unknown Object (File)
	Oct 7 2024, 1:45 PM

	Unknown Object (File)
	Oct 7 2024, 4:50 AM

	Unknown Object (File)
	Oct 6 2024, 8:52 AM

Subscribers

Details

Reviewers

varun
• karol
tomek
• jon

Commits

rCOMM6271350404db: [services] Tunnelbroker - Install Rust and Corrosion in Dockerfile

Summary

Install Curl, Rust, Cargo using RustUp script and run the Corrosion installation script from D4496 in Dockerfile.

Linear task: ENG-1329

Test Plan

Rust, Cargo, and Corrosion are successfully installed inside the Docker container.
To make sure it's installed we can run the rustc --version and cargo --version commands inside the running container.
Also building with Corrosion as a dependency in D4498 finishing with success.

Diff Detail

Repository

Branch

install-rust-in-dockerfile

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Jul 11 2022, 4:34 AM

• max held this revision as a draft.

Herald added subscribers: • abosh, • karol, atul and 3 others. · View Herald TranscriptJul 11 2022, 4:34 AM

• max added a parent revision: D4496: [services] Tunnelbroker - Add Corrosion installation script.Jul 11 2022, 4:37 AM

• max added a child revision: D4498: [services] Tunnelbroker - Add Corrosion to CMakeLists.Jul 11 2022, 4:43 AM

Harbormaster completed remote builds in B10445: Diff 14389.Jul 11 2022, 4:46 AM

• max edited the summary of this revision. (Show Details)Jul 11 2022, 4:55 AM

• max edited the test plan for this revision. (Show Details)

• max added reviewers: varun, • karol, tomek.

• max added 1 blocking reviewer(s): varun.

• max published this revision for review.Jul 11 2022, 5:05 AM

• max edited the summary of this revision. (Show Details)

• max added inline comments.Jul 11 2022, 5:10 AM

services/tunnelbroker/Dockerfile
9	Curl installation can be split in a separate diff, but I think it's better to review (for reviewers) these changes in one.

Adding @jonringer-comm since it's CMake/Rust-related. Also removed @palys-swm as blocking to give him a break :)

Seems to be continuing continuing already established docker paradigms

varun accepted this revision.Jul 12 2022, 12:17 PM

This revision is now accepted and ready to land.Jul 12 2022, 12:17 PM

Closed by commit rCOMM6271350404db: [services] Tunnelbroker - Install Rust and Corrosion in Dockerfile (authored by • max). · Explain WhyJul 14 2022, 6:25 AM

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMM6271350404db: [services] Tunnelbroker - Install Rust and Corrosion in Dockerfile.

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

8 lines

Diff 14389

services/tunnelbroker/Dockerfile

Loading...