grpc.cmake
ClosedPublic
Actions

Authored by • jon on Jul 18 2022, 11:24 PM.

Details

Reviewers

atul
varun
• max
• karol

Commits

rCOMMda9e2fc2f98f: [Chore] Lint services/lib/cmake-components/grpc.cmake

Summary

Lint cmake helper file

Test Plan

nix develop
cmake-lint services/backup/CMakeLists.txt

Depends on D4564

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Jul 18 2022, 11:24 PM

Herald added subscribers: • abosh, • adrian, tomek, ashoat. · View Herald TranscriptJul 18 2022, 11:24 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 18 2022, 11:28 PM

Harbormaster failed remote builds in B10606: Diff 14599!

Rebase

• jon added a child revision: D4548: [BuildKite] Add cmake lint gate.Jul 18 2022, 11:43 PM

Harbormaster completed remote builds in B10611: Diff 14604.Jul 18 2022, 11:55 PM

• jon requested review of this revision.Jul 18 2022, 11:55 PM

atul accepted this revision.Jul 19 2022, 1:00 AM

This revision is now accepted and ready to land.Jul 19 2022, 1:00 AM

Closed by commit rCOMMda9e2fc2f98f: [Chore] Lint services/lib/cmake-components/grpc.cmake. · Explain WhyJul 20 2022, 7:00 PM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMMda9e2fc2f98f: [Chore] Lint services/lib/cmake-components/grpc.cmake.

Revision Contents
Changeset List

Path

Size

services/

lib/

cmake-components/

grpc.cmake

3 lines

Diff 14604

View Options

services/lib/cmake-components/grpc.cmake

[Chore] Lint services/lib/cmake-components/grpc.cmakeClosedPublicActions