grpc.cmake
ClosedPublic
Actions

Authored by • jon on Jul 18 2022, 4:24 PM.

Tags

None

Referenced Files

	F3562553: D4569.id14724.diff
	Fri, Dec 27, 10:54 AM

	F3562551: D4569.id14604.diff
	Fri, Dec 27, 10:54 AM

	F3562550: D4569.id14599.diff
	Fri, Dec 27, 10:54 AM

	F3562486: D4569.id.diff
	Fri, Dec 27, 10:53 AM

	F3562405: D4569.diff
	Fri, Dec 27, 10:43 AM

	Unknown Object (File)
	Wed, Dec 18, 4:17 AM

	Unknown Object (File)
	Fri, Dec 13, 2:55 AM

	Unknown Object (File)
	Mon, Dec 9, 10:20 AM

Subscribers

Details

Reviewers

atul
varun
• max
• karol

Commits

rCOMMda9e2fc2f98f: [Chore] Lint services/lib/cmake-components/grpc.cmake

Summary

Lint cmake helper file

Test Plan

nix develop
cmake-lint services/backup/CMakeLists.txt

Depends on D4564

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Jul 18 2022, 4:24 PM

Herald added subscribers: • abosh, • adrian, tomek, ashoat. · View Herald TranscriptJul 18 2022, 4:24 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 18 2022, 4:28 PM

Harbormaster failed remote builds in B10606: Diff 14599!

Rebase

• jon added a child revision: D4548: [BuildKite] Add cmake lint gate.Jul 18 2022, 4:43 PM

Harbormaster completed remote builds in B10611: Diff 14604.Jul 18 2022, 4:55 PM

• jon requested review of this revision.Jul 18 2022, 4:55 PM

atul accepted this revision.Jul 18 2022, 6:00 PM

This revision is now accepted and ready to land.Jul 18 2022, 6:00 PM

Closed by commit rCOMMda9e2fc2f98f: [Chore] Lint services/lib/cmake-components/grpc.cmake (authored by • jon). · Explain WhyJul 20 2022, 12:00 PM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMMda9e2fc2f98f: [Chore] Lint services/lib/cmake-components/grpc.cmake.

Revision Contents
Changeset List

Path

Size

services/

lib/

cmake-components/

grpc.cmake

3 lines

Diff 14604

View Options

services/lib/cmake-components/grpc.cmake

[Chore] Lint services/lib/cmake-components/grpc.cmakeClosedPublicActions