Page MenuHomePhabricator

[Chore] Lint services/tunnelbroker/CMakeLists.txt
ClosedPublic

Authored by jon on Jul 18 2022, 4:20 PM.
Tags
None
Referenced Files
F3280526: D4566.id14723.diff
Sat, Nov 16, 9:12 AM
F3280425: D4566.id14605.diff
Sat, Nov 16, 9:09 AM
Unknown Object (File)
Sun, Oct 27, 3:58 PM
Unknown Object (File)
Sun, Oct 27, 6:55 AM
Unknown Object (File)
Sun, Oct 27, 6:55 AM
Unknown Object (File)
Sun, Oct 27, 6:55 AM
Unknown Object (File)
Sun, Oct 27, 6:55 AM
Unknown Object (File)
Sun, Oct 27, 6:55 AM

Details

Summary

Lint tunnelbroker's cmake

Test Plan
nix develop
cmake-lint services/backup/CMakeLists.txt

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 18 2022, 4:27 PM
Harbormaster failed remote builds in B10603: Diff 14596!

Apply refactor throughout referrers

This revision is now accepted and ready to land.Jul 18 2022, 6:00 PM

Small note on this stack – personally I probably would've put all of the lint results into a single diff. We generally prefer small diffs, but it's really all about making life easier for the reviewer. When there are code changes, separating into smaller diffs makes review easier, but sometimes large diffs can be easier to review.

noted, guess for this one there likely wouldn't be much commentary anyway.