Depends on D4581
Adding the logic for the put operations.
Details
Details
cd services yarn run-performance-tests blob
You may run this but running it again will result in a failed test. This is because the data are not going to be removed in the end so you'll get "the data already exists" error. In this case, you may want to run:
yarn reset-local-cloud
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| services/commtest/tests/blob_performance_test.rs | ||
|---|---|---|
| 54 ↗ | (On Diff #14681) | should be removed |
| services/commtest/tests/blob_performance_test.rs | ||
|---|---|---|
| 18–21 | Indentation is weird here (I would expect lines 19 and 21 to be indented extra) but if that is the Rust formatter's opinion, then okay | |
| services/commtest/tests/blob_performance_test.rs | ||
|---|---|---|
| 46–50 | I don't see why we would use a map here. for is the simplest and the clearest possible approach I can see. Why would we use a map here? | |
| 53 | Because at the end of this test, we remove the data, the successful test covers adding, reading, and removing the data. You interpreted this output wrong: it's not like the "data doesn't exist after the put". This result tells us whether the data already existed before the put or it did not - only in the latter case, the data is being put in the storage. | |