Page MenuHomePhabricator
Differential D4583

[services] Tests - Add GET for Blob performance tests
ClosedPublic
Actions

Authored by • karol on Jul 20 2022, 4:15 AM.
Tags
None
Referenced Files
F3506700: D4583.diff
Fri, Dec 20, 5:56 PM
Unknown Object (File)
Tue, Dec 17, 7:03 AM
Unknown Object (File)
Tue, Dec 17, 7:03 AM
Unknown Object (File)
Tue, Dec 17, 7:03 AM
Unknown Object (File)
Mon, Dec 16, 1:24 PM
Unknown Object (File)
Mon, Dec 16, 7:19 AM
Unknown Object (File)
Mon, Dec 16, 7:19 AM
Unknown Object (File)
Mon, Dec 16, 7:19 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
tomek
varun
Commits
rCOMMf072e4778c10: [services] Tests - Add GET for Blob performance tests
Summary

Depends on D4582

Adding the logic for the get operations.

Test Plan
cd services
yarn run-performance-tests blob

You may run this but running it again will result in a failed test. This is because the data are not going to be removed in the end so you'll get "the data already exists" error. In this case, you may want to run:

yarn reset-local-cloud

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.Jul 20 2022, 4:15 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJul 20 2022, 4:15 AM
• karol edited the summary of this revision. (Show Details)Jul 20 2022, 4:35 AM
• karol edited the test plan for this revision. (Show Details)
• karol added a parent revision: D4582: [services] Tests - Add PUT for Blob performance tests.
• karol added a child revision: D4584: [services] Tests - Add REMOVE for Blob performance tests.
• karol added inline comments.
services/commtest/tests/blob_performance_test.rs
75 ↗(On Diff #14682)

should be removed

• karol updated this revision to Diff 14687.Jul 20 2022, 4:40 AM
• karol edited the summary of this revision. (Show Details)

remove log line

Harbormaster completed remote builds in B10665: Diff 14682.Jul 20 2022, 4:41 AM
• karol published this revision for review.Jul 20 2022, 4:59 AM
• karol planned changes to this revision.
• karol updated this revision to Diff 14693.Jul 20 2022, 5:01 AM

lazily add stuff

Harbormaster completed remote builds in B10670: Diff 14687.Jul 20 2022, 5:12 AM
Harbormaster completed remote builds in B10675: Diff 14693.Jul 20 2022, 5:45 AM
• karol added reviewers: tomek, varun.Jul 21 2022, 2:32 AM
tomek accepted this revision.Jul 21 2022, 4:55 AM
This revision is now accepted and ready to land.Jul 21 2022, 4:55 AM
• karol updated this revision to Diff 14801.Jul 22 2022, 1:36 AM

rebase

Harbormaster completed remote builds in B10760: Diff 14801.Jul 22 2022, 1:49 AM
• karol updated this revision to Diff 15052.Jul 28 2022, 6:11 AM

rebase

Harbormaster completed remote builds in B10942: Diff 15052.Jul 28 2022, 6:26 AM
Closed by commit rCOMMf072e4778c10: [services] Tests - Add GET for Blob performance tests (authored by • karol). · Explain WhyAug 2 2022, 3:02 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMMf072e4778c10: [services] Tests - Add GET for Blob performance tests.

Revision Contents
Changeset List

PathSize
services/
commtest/
tests/
24 lines

Diff 14693

View Options

services/commtest/tests/blob_performance_test.rs

Loading...