Page MenuHomePhabricator
Differential D4472

Extend TemporaryMessageStore interface with private auxiliary methods to manipulate paths
ClosedPublic
Actions

Authored by marcin on Jul 7 2022, 5:38 AM.
Tags
None
Referenced Files
F3383855: D4472.id14698.diff
Thu, Nov 28, 6:03 PM
F3383745: D4472.id14638.diff
Thu, Nov 28, 5:30 PM
F3383701: D4472.id14259.diff
Thu, Nov 28, 5:21 PM
Unknown Object (File)
Mon, Nov 25, 2:53 AM
Unknown Object (File)
Mon, Nov 25, 12:47 AM
Unknown Object (File)
Mon, Nov 11, 7:52 PM
Unknown Object (File)
Mon, Nov 11, 7:19 PM
Unknown Object (File)
Mon, Nov 11, 2:37 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul

Details

Reviewers
tomek
Commits
rCOMMd544b3ddcbfb: Extend TemporaryMessageStore interface with private auxiliary methods to…
Summary

Adds and implements private methods to manipulate file names and create latest file to store messages

Test Plan

We can temporarily modify AppDelegate to invoke thos methods and check in the debugger that _getPath and getLockName return valid string and _updateCurrentStorage creates new file with expected name

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.Jul 7 2022, 5:38 AM
Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptJul 7 2022, 5:38 AM
marcin updated this revision to Diff 14259.Jul 7 2022, 5:41 AM

Edit commit message

Harbormaster completed remote builds in B10350: Diff 14258.Jul 7 2022, 6:09 AM
Harbormaster completed remote builds in B10351: Diff 14259.Jul 7 2022, 6:16 AM
marcin requested review of this revision.Jul 7 2022, 6:16 AM
ashoat added a comment.Jul 7 2022, 6:39 AM

Hey @marcinwasowicz, can you go through your entire diff stack and remove any reference to "Temporal", replacing it with "Temporary"?

marcin updated this revision to Diff 14276.Jul 7 2022, 7:10 AM

Rename Temporal to Temporary

marcin added a parent revision: D4392: Implement flat-file based message storage initialization.Jul 7 2022, 7:16 AM
marcin retitled this revision from Extend TemporalMessageStore interface with private auxiliary methods to manipulate paths to Extend TemporaryMessageStore interface with private auxiliary methods to manipulate paths.
marcin added a child revision: D4393: Implement write operation for flat-file based message storage.
In D4472#126964, @ashoat wrote:

Hey @marcinwasowicz, can you go through your entire diff stack and remove any reference to "Temporal", replacing it with "Temporary"?

Temporal is renamed to Temporary in entire codebase of this stack as well as in differentials descriptions and titles.

Harbormaster completed remote builds in B10368: Diff 14276.Jul 7 2022, 8:12 AM
tomek accepted this revision.Jul 8 2022, 3:08 AM
tomek added inline comments.
native/ios/Comm/TemporaryMessageStorage/TemporaryMessageStorage.mm
42 ↗(On Diff #14276)

Maybe createNewStorage so that it is less confusing? The current name might indicate that we're renaming a storage.

This revision is now accepted and ready to land.Jul 8 2022, 3:08 AM
marcin added inline comments.Jul 11 2022, 7:13 AM
native/ios/Comm/TemporaryMessageStorage/TemporaryMessageStorage.mm
42 ↗(On Diff #14276)

Sure, I will do the refactor.

marcin updated this revision to Diff 14427.Jul 13 2022, 3:47 AM

Rename new storage creation method and re-implement it to use fopen

Harbormaster completed remote builds in B10480: Diff 14427.Jul 13 2022, 3:59 AM
marcin updated this revision to Diff 14469.Jul 14 2022, 4:50 AM

Rebase

Harbormaster completed remote builds in B10520: Diff 14469.Jul 14 2022, 5:34 AM
tomek accepted this revision.Jul 18 2022, 6:22 AM
marcin updated this revision to Diff 14638.Jul 19 2022, 5:52 AM

Rebase

Harbormaster completed remote builds in B10639: Diff 14638.Jul 19 2022, 6:05 AM
marcin updated this revision to Diff 14698.Jul 20 2022, 5:22 AM

Rebase master

This revision was landed with ongoing or failed builds.Jul 20 2022, 6:17 AM
Closed by commit rCOMMd544b3ddcbfb: Extend TemporaryMessageStore interface with private auxiliary methods to… (authored by marcin). · Explain Why
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMd544b3ddcbfb: Extend TemporaryMessageStore interface with private auxiliary methods to….
Harbormaster completed remote builds in B10680: Diff 14698.Jul 20 2022, 6:19 AM

Revision Contents
Changeset List

PathSize
native/
ios/
Comm/
TemporaryMessageStorage/
32 lines

Diff 14704

View Options

native/ios/Comm/TemporaryMessageStorage/TemporaryMessageStorage.mm

Loading...