Included all of these functions in a single diff because they all do the same thing - block the tokio runtime on the completion of their equivalent async fns
Depends on D4936
Paths
| Differential D4937 Authored by varun on Aug 23 2022, 10:45 PM.
Details
Summary Included all of these functions in a single diff because they all do the same thing - block the tokio runtime on the completion of their equivalent async fns Depends on D4936 Test Plan tested in the following diff where we expose these blocking functions in the ffi module
Diff Detail
Event TimelineHerald added subscribers: • abosh, ashoat. · View Herald TranscriptAug 23 2022, 10:45 PM2022-08-23 22:45:47 (UTC-7) Harbormaster completed remote builds in B11566: Diff 15902.Aug 23 2022, 10:55 PM2022-08-23 22:55:05 (UTC-7) Comment Actions Looks ok, but have you considered creating a macro instead of having a couple of functions that do the same thing? This revision is now accepted and ready to land.Aug 24 2022, 3:16 AM2022-08-24 03:16:10 (UTC-7) Comment Actions
This is a good idea, I'm just not very experienced writing macros. Added to the improvement task on Linear Closed by commit rCOMM9513c6d53357: [native] more blocking functions (authored by varun). · Explain WhyAug 25 2022, 3:57 AM2022-08-25 03:57:27 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 15902 native/cpp/CommonCpp/grpc/grpc_client/src/lib.rs
|