Page MenuHomePhabricator

[CMake] Use correct protobuf capitalization
ClosedPublic

Authored by jon on Sep 9 2022, 4:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 2:19 PM
Unknown Object (File)
Sat, Nov 9, 1:47 PM
Unknown Object (File)
Sat, Nov 9, 11:24 AM
Unknown Object (File)
Sat, Nov 9, 10:41 AM
Unknown Object (File)
Sat, Nov 9, 7:41 AM
Unknown Object (File)
Sat, Nov 9, 7:22 AM
Unknown Object (File)
Wed, Oct 23, 10:10 AM
Unknown Object (File)
Wed, Oct 16, 11:28 PM
Subscribers

Details

Summary

Fix failure from D4998#14767.

Correctly capitalizing the package name prevents cmake from
visiting all potential cmake configs and polluting the
environment with potentially conflicting packages outside
of the nix environment.

Test Plan
nix develop
cd services/blob
rm -rf build && mkdir build && cd build && cmake .. && make -j

Diff Detail

Repository
rCOMM Comm
Branch
jonringer/minor-fixes (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 9 2022, 4:58 PM
Harbormaster failed remote builds in B12065: Diff 16565!
Harbormaster returned this revision to the author for changes because remote builds failed.Sep 9 2022, 5:01 PM
Harbormaster failed remote builds in B12066: Diff 16566!
This revision is now accepted and ready to land.Sep 12 2022, 7:39 AM