Page MenuHomePhabricator
Differential D5110

[web] Fix warning - set readOnly param to EnumSettingOption radio
ClosedPublic
Actions

Authored by • jakub on Sep 12 2022, 5:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 8:00 PM
Unknown Object (File)
Mon, Nov 25, 4:22 PM
Unknown Object (File)
Fri, Nov 8, 8:32 PM
Unknown Object (File)
Thu, Nov 7, 9:19 PM
Unknown Object (File)
Thu, Nov 7, 9:19 PM
Unknown Object (File)
Thu, Nov 7, 9:09 PM
Unknown Object (File)
Thu, Nov 7, 7:17 PM
Unknown Object (File)
Oct 9 2024, 3:17 AM
View All Files
Subscribers
• abosh
ashoat
atul
tomek

Details

Reviewers
tomek
atul
Commits
rCOMM692c8b02a310: [web] Fix warning - set readOnly param to EnumSettingOption radio
Summary

Fixing warning that occur on controlled radio input in EnumSettingsOption

Warning communiqué:

Screenshot 2022-09-12 at 14.49.09.png (974×1 px, 321 KB)

Test Plan
  1. Open console
  2. Open any modal that uses EnumSettingOption (e.g. channel notification modal)
  3. Now, this warning doesn't appear

Diff Detail

Repository
rCOMM Comm
Branch
jakub/channel-composer
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jakub created this revision.Sep 12 2022, 5:55 AM
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptSep 12 2022, 5:55 AM
• jakub edited the summary of this revision. (Show Details)Sep 12 2022, 6:03 AM
• jakub edited the test plan for this revision. (Show Details)
• jakub added reviewers: tomek, atul, ashoat.
Harbormaster completed remote builds in B12080: Diff 16580.Sep 12 2022, 6:05 AM
• jakub requested review of this revision.Sep 12 2022, 6:05 AM
• jakub added a child revision: D5113: [web] Introducing `ModalLabel` component.Sep 12 2022, 8:22 AM
atul requested changes to this revision.Sep 15 2022, 7:45 AM

Accepting with question

Do we not want this Radio component to be interactive, or is this readOnly included temporary until onChange is implemented?

This revision now requires changes to proceed.Sep 15 2022, 7:45 AM
atul accepted this revision.Sep 15 2022, 7:45 AM
This revision is now accepted and ready to land.Sep 15 2022, 7:45 AM
atul removed a reviewer: ashoat.Sep 15 2022, 7:45 AM
• jakub added a comment.Sep 16 2022, 12:59 AM

By default, this Radio component is only used in and controlled by EnumSettingsOption component. So basically, we don't need to pass any onChange function to them.

Closed by commit rCOMM692c8b02a310: [web] Fix warning - set readOnly param to EnumSettingOption radio (authored by • jakub). · Explain WhySep 16 2022, 1:09 AM
This revision was automatically updated to reflect the committed changes.
• jakub added a commit: rCOMM692c8b02a310: [web] Fix warning - set readOnly param to EnumSettingOption radio.
tomek added inline comments.Sep 16 2022, 8:30 AM
web/components/radio.react.js
10–13 ↗(On Diff #16732)

Can we introduce a new prop readOnly to this component so that it remains usable in different contexts?

• jakub added a child revision: D5115: [web] Added possibility to change input type and icon position in EnumSettingsOption.Sep 26 2022, 3:30 AM

Revision Contents
Changeset List

PathSize
web/
components/
4 lines

Diff 16580

View Options

web/components/radio.react.js

Loading...