Differential D5121

[Services] Avoid using GTest in docker
ClosedPublic
Actions

Authored by • jon on Sep 12 2022, 2:01 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 9, 12:28 AM

	Unknown Object (File)
	Sun, Apr 6, 7:30 AM

	Unknown Object (File)
	Mon, Mar 17, 4:12 AM

	Unknown Object (File)
	Mon, Mar 17, 4:12 AM

	Unknown Object (File)
	Mon, Mar 17, 4:12 AM

	Unknown Object (File)
	Mon, Mar 17, 4:12 AM

	Unknown Object (File)
	Sun, Mar 16, 6:12 PM

	Unknown Object (File)
	Mar 12 2025, 8:29 PM

Subscribers

Details

Reviewers

• max
atul
• abosh
varun
• karol
tomek

Commits

rCOMM2e355ef44e35: [Services] Avoid using GTest in docker

Summary

The test suites for services require gtest, however, it's not
currently available in our docker workflow.

This is in preparation of other changes which will use BUILD_TESTING to
determine if the test suite should be built.

Test Plan

Services CI gates pass

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Sep 12 2022, 2:01 PM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 12 2022, 2:01 PM

• jon added a child revision: D5118: [Services] Use BUILD_TESTING for tunnelbroker build.Sep 12 2022, 2:03 PM

• jon added a child revision: D5117: [Services] Fix backup test suite build.

• jon added a child revision: D5116: [Services] Fix blob test build.

Harbormaster completed remote builds in B12097: Diff 16604.Sep 12 2022, 2:09 PM

• jon requested review of this revision.Sep 12 2022, 2:09 PM

atul accepted this revision.Sep 13 2022, 9:40 AM

This revision is now accepted and ready to land.Sep 13 2022, 9:40 AM

Closed by commit rCOMM2e355ef44e35: [Services] Avoid using GTest in docker (authored by • jon). · Explain WhySep 13 2022, 11:45 AM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMM2e355ef44e35: [Services] Avoid using GTest in docker.

Revision Contents
Changeset List

Path

Size

services/

lib/

docker/

build_sources.sh

3 lines

Diff 16604

services/lib/docker/build_sources.sh

	Show First 20 Lines • Show All 263 Lines • ▼ Show 20 Lines		unsafe extern "C++" {
	fn get_backup_directory_path() -> Result<String>;			fn get_backup_directory_path() -> Result<String>;

	#[allow(unused)]			#[allow(unused)]
	#[cxx_name = "getBackupFilePath"]			#[cxx_name = "getBackupFilePath"]
	fn get_backup_file_path(			fn get_backup_file_path(
	backup_id: String,			backup_id: String,
	is_attachments: bool,			is_attachments: bool,
	) -> Result<String>;			) -> Result<String>;

				#[allow(unused)]
				#[cxx_name = "createMainCompaction"]
				fn create_main_compaction(backup_id: String) -> Result<()>;

				#[allow(unused)]
				#[cxx_name = "restoreFromMainCompaction"]
				fn restore_from_main_compaction(
				main_compaction_path: String,
				main_compaction_encryption_key: String,
				) -> Result<()>;
	}			}
	}			}

	fn handle_string_result_as_callback<E>(			fn handle_string_result_as_callback<E>(
	result: Result<String, E>,			result: Result<String, E>,
	promise_id: u32,			promise_id: u32,
	) where			) where
	E: std::fmt::Display,			E: std::fmt::Display,
	▲ Show 20 Lines • Show All 896 Lines • Show Last 20 Lines