Page MenuHomePhabricator
Differential D5215

Define type for <F>(serverCall: ActionFunc<F>) => F
ClosedPublic
Actions

Authored by inka on Sep 22 2022, 7:38 AM.
Tags
None
Referenced Files
F3347943: D5215.diff
Fri, Nov 22, 1:37 PM
Unknown Object (File)
Tue, Nov 5, 10:02 AM
Unknown Object (File)
Tue, Nov 5, 10:02 AM
Unknown Object (File)
Tue, Nov 5, 10:02 AM
Unknown Object (File)
Tue, Nov 5, 10:02 AM
Unknown Object (File)
Tue, Nov 5, 10:01 AM
Unknown Object (File)
Tue, Nov 5, 9:57 AM
Unknown Object (File)
Oct 20 2024, 10:02 AM
View All Files
Subscribers
• abosh
ashoat
atul

Details

Reviewers
tomek
michal
• jakub
marcin
Commits
rCOMMf20b9fc8314f: Define type for <F>(serverCall: ActionFunc<F>) => F
Summary

Linear issue: ENG-1845. Defining a type for <F>(serverCall: ActionFunc<F>) => F for code clarity.

Test Plan

See that it is still possible to remove a user as a friend.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Sep 22 2022, 7:38 AM
Herald added subscribers: • abosh, atul, ashoat. · View Herald TranscriptSep 22 2022, 7:38 AM
inka added a child revision: D5109: [native] Add client side logic of message reporting.Sep 22 2022, 7:39 AM
inka edited the summary of this revision. (Show Details)Sep 22 2022, 7:41 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Sep 22 2022, 7:44 AM
Harbormaster failed remote builds in B12384: Diff 17000!
Harbormaster completed remote builds in B12384: Diff 17000.Sep 22 2022, 7:49 AM
inka requested review of this revision.Sep 22 2022, 7:49 AM
atul added inline comments.Sep 22 2022, 7:53 AM
lib/utils/action-utils.js
349

Nit: probably supposed to be BindServerCall instead of BindSeverCall

inka added inline comments.Sep 22 2022, 8:10 AM
lib/utils/action-utils.js
349

Thank you for noticing!

inka updated this revision to Diff 17002.Sep 22 2022, 8:10 AM

Fix typo

Harbormaster failed remote builds in B12386: Diff 17002!Sep 22 2022, 8:17 AM
Harbormaster completed remote builds in B12386: Diff 17002.Sep 23 2022, 7:34 AM
tomek accepted this revision.Sep 23 2022, 9:12 AM
This revision is now accepted and ready to land.Sep 23 2022, 9:12 AM
inka updated this revision to Diff 17222.Sep 30 2022, 3:52 AM

Rebase

Harbormaster completed remote builds in B12551: Diff 17222.Sep 30 2022, 4:05 AM
Closed by commit rCOMMf20b9fc8314f: Define type for <F>(serverCall: ActionFunc<F>) => F (authored by • InkaSokolowska). · Explain WhySep 30 2022, 5:27 AM
This revision was automatically updated to reflect the committed changes.
• InkaSokolowska added a commit: rCOMMf20b9fc8314f: Define type for <F>(serverCall: ActionFunc<F>) => F.

Revision Contents
Changeset List

Diff 17000

View Options

lib/utils/action-utils.js

Loading...
View Options

native/chat/settings/thread-settings-member-tooltip-modal.react.js

Loading...
View Options

native/chat/sidebar-navigation.js

Loading...
View Options

native/chat/text-message-tooltip-modal.react.js

Loading...
View Options

native/navigation/tooltip.react.js

Loading...
View Options

native/profile/relationship-list-item-tooltip-modal.react.js

Loading...