[native] memoized textStyle and styles.text
ClosedPublic
Actions

Authored by ginsu on Sep 28 2022, 12:12 PM.

Details

Reviewers

atul
• abosh
rohan
kamil

Commits

rCOMM013cf5a51ca8: [native] memoized textStyle and styles.text

Summary

memoized textStyle and styles.text into markdownStyles for improved performance

Test Plan

Open a chat with any markdown components (blockquote, codeblock, etc) and everything should be the same

Diff Detail

Repository

rCOMM Comm

Branch

eng-1712-native (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Sep 28 2022, 12:12 PM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptSep 28 2022, 12:12 PM

ginsu edited the summary of this revision. (Show Details)Sep 28 2022, 12:12 PM

ginsu added reviewers: atul, • abosh, rohan.

ginsu added a reviewer: kamil.

Harbormaster completed remote builds in B12501: Diff 17156.Sep 28 2022, 12:22 PM

ginsu requested review of this revision.Sep 28 2022, 12:22 PM

Thanks for separating this out!

This revision is now accepted and ready to land.Sep 28 2022, 1:02 PM

Saw this initially in your other diff, the separation looks good to me

Closed by commit rCOMM013cf5a51ca8: [native] memoized textStyle and styles.text (authored by ginsu). · Explain WhySep 29 2022, 2:24 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM013cf5a51ca8: [native] memoized textStyle and styles.text.

Revision Contents
Changeset List

Path

Size

native/

chat/

inner-text-message.react.js

16 lines

Diff 17156

View Options

native/chat/inner-text-message.react.js

[native] memoized textStyle and styles.textClosedPublicActions