Paths

Table of Contentst

[native] memoized textStyle and styles.text
ClosedPublic
Actions

Authored by ginsu on Sep 28 2022, 12:12 PM.

Tags

None

Referenced Files

	F1774675: D5251.id17212.diff
	Thu, May 16, 3:15 AM

	F1774656: D5251.id.diff
	Thu, May 16, 2:41 AM

	Unknown Object (File)
	Tue, May 14, 7:50 AM

	Unknown Object (File)
	Mon, Apr 29, 11:16 AM

	Unknown Object (File)
	Sun, Apr 21, 9:01 AM

	Unknown Object (File)
	Sun, Apr 21, 9:01 AM

	Unknown Object (File)
	Sun, Apr 21, 9:01 AM

	Unknown Object (File)
	Sun, Apr 21, 8:56 AM

Subscribers

Details

Reviewers

atul
• abosh
rohan
kamil

Commits

rCOMM013cf5a51ca8: [native] memoized textStyle and styles.text

Summary

memoized textStyle and styles.text into markdownStyles for improved performance

Test Plan

Open a chat with any markdown components (blockquote, codeblock, etc) and everything should be the same

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Sep 28 2022, 12:12 PM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptSep 28 2022, 12:12 PM

ginsu edited the summary of this revision. (Show Details)Sep 28 2022, 12:12 PM

ginsu added reviewers: atul, • abosh, rohan.

ginsu added a reviewer: kamil.

Harbormaster completed remote builds in B12501: Diff 17156.Sep 28 2022, 12:22 PM

ginsu requested review of this revision.Sep 28 2022, 12:22 PM

Thanks for separating this out!

This revision is now accepted and ready to land.Sep 28 2022, 1:02 PM

Saw this initially in your other diff, the separation looks good to me

Closed by commit rCOMM013cf5a51ca8: [native] memoized textStyle and styles.text (authored by ginsu). · Explain WhySep 29 2022, 2:24 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM013cf5a51ca8: [native] memoized textStyle and styles.text.

Revision Contents
Changeset List

Path

Size

native/

chat/

inner-text-message.react.js

16 lines

Diff 17212

View Options

native/chat/inner-text-message.react.js

[native] memoized textStyle and styles.textClosedPublicActions