[native] Disable Delete chat button when trying to delete a chat and the password input is empty
ClosedPublic
Actions

Authored by rohan on Oct 9 2022, 10:40 AM.

Details

Reviewers

atul
ginsu
• abosh

Commits

rCOMM50a6b2438ec8: [native] Disable Delete chat button when trying to delete a chat and the…

Summary

Disable the button if the password is empty, and also handle the
enter button from being pressed within the input field and make sure not
to attempt to disable the thread.

Test Plan

Tested both cases where the button becomes unclickable and
pressing enter within the input field should not submit the contents of
the field

Demo:

Diff Detail

Repository

rCOMM Comm

Branch

ENG-1920

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

rohan created this revision.Oct 9 2022, 10:40 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 9 2022, 10:40 AM

rohan edited the test plan for this revision. (Show Details)Oct 9 2022, 10:42 AM

rohan attached a referenced file: F194390: ENG-1920.mov. (Show Details)

Harbormaster completed remote builds in B12680: Diff 17429.Oct 9 2022, 10:51 AM

rohan requested review of this revision.Oct 9 2022, 10:51 AM

Looks good!

native/chat/settings/delete-thread.react.js
234	We could probably just drop the `Common` suffix here. If we do want to include something in the name to indicate that this style is "shared" across different states, we tend to use the word `Base` elsewhere in the codebase... so maybe `deleteButtonBase` or `baseDeleteButton`? Doesn't really matter, up to you