Page MenuHomePhabricator
Differential D5331

[Nix] Use clang from XCode
AbandonedPublicDraft
Actions

Authored by • jon on Oct 10 2022, 7:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 28, 11:32 PM
Unknown Object (File)
Thu, Nov 28, 11:31 PM
Unknown Object (File)
Wed, Nov 27, 10:59 PM
Unknown Object (File)
Sun, Nov 24, 12:32 PM
Unknown Object (File)
Oct 26 2024, 9:41 PM
Unknown Object (File)
Oct 26 2024, 9:41 PM
Unknown Object (File)
Oct 26 2024, 9:41 PM
Unknown Object (File)
Oct 26 2024, 9:37 PM
View All Files
Subscribers
atul

Details

Reviewers
varun
tomek
ashoat
• abosh
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

Allow for the default version of clang to be used so that it's able to find
frameworks and other dependencies distributed alongside XCode.

https://linear.app/comm/issue/ENG-1948
Related item - https://linear.app/comm/issue/ENG-1947

Branch - jonringer/remove-nix-clang

Test Plan
nix develop
cd native
RUST_BACKTRACE=1 yarn react-native run-ios --configuration=Release
# Should be able to find iOS frameworks, and build successfully

Diff Detail

Repository
rCOMM Comm
Branch
jonringer/remove-nix-clang (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Oct 10 2022, 7:26 AM
Owners added a reviewer: Restricted Owners Package.Oct 10 2022, 7:26 AM
Herald added a subscriber: atul. · View Herald TranscriptOct 10 2022, 7:26 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 10 2022, 7:27 AM
Harbormaster failed remote builds in B12699: Diff 17451!
• jon added a parent revision: D5338: [Services] Force c++17 usage with cxx builds.Oct 10 2022, 2:53 PM
• jon updated this revision to Diff 17466.Oct 10 2022, 2:53 PM

Rebase with fixes

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 10 2022, 2:55 PM
Harbormaster failed remote builds in B12714: Diff 17466!
• jon abandoned this revision.Nov 10 2022, 10:29 AM

No longer relevant after https://phab.comm.dev/D5508

Revision Contents
Changeset List

PathSize
nix/
11 lines

Diff 17466

View Options

nix/dev-shell.nix

Loading...