@marcin, for each of these changes can you add a comment explaining why it is necessary? I was under the impression that the GlobalDBSingleton work would make these temporary changes unnecessary... not opposed to them, just want to understand why we still need some temporary changes

In D5332#157323, @ashoat wrote:

@marcin, for each of these changes can you add a comment explaining why it is necessary? I was under the impression that the GlobalDBSingleton work would make these temporary changes unnecessary... not opposed to them, just want to understand why we still need some temporary changes

Those changes are not related to global db singleton. Some time ago we had theory that iOS 173 crash was caused be the fact that encryption key used for database encryption is available only WHEN_UNLOCKED since expo docs state that this is default value for accessibility option and we didn't specify any value for accessibility option. We created a release build with changes that explicitly set accessibility options to AFTER_FIRST_UNLOCK. Then I searched through expo's source code and found that there is a bug - even though docs said WHEN_UNLOCKED is default actually AFTER_FIRST_UNLOCK was the default. Changes above appeared to be no-op then, but we kept attaching them to each release build. The reason to keep them might be that I immediately informed expo team (at SWM) about the bug and they promised te resolve it quickly. I didn't check in their source code if they did. If they did we need those changes - if they didn't those changes are unnecessary now, but might be in the future once they resolve the bug.

The context for encryptionKey accessibility migration code is in this differential we have probably forgotten about: https://phab.comm.dev/D4795. In this differential code was accepted as release-friendly but not landable. For landing I will need to introduce changes requested here but personally I wouldn't block release on this but rather create high priority Linear task for that.

For landing I will need to introduce changes requested here but personally I wouldn't block release on this but rather create high priority Linear task for that.

Thanks @marcin, can you create a task to follow-up on this?

Passing this back to @atul – one change requested inline and one question, and then we can move forward with the release

Created task: https://linear.app/comm/issue/ENG-2010/refactor-encryptionkey-accessibility-options-migration-code-so-that-it. I have most context on this so I am probably best choice if we want to land is ASAP, but I am open for other team members to work on this task since it is not that complex (and core logic is already implemented). Perhaps @bartek could be a good person since he is former expo member and this task deals with expo.