[IGNORE][CommCoreModule] `ROLLBACK` if migration idx <= db_version_inside_transaction
AbandonedPublic
Actions

Authored by atul on Oct 20 2022, 8:59 AM.

Tags

None

Referenced Files

	F3246538: D5441.diff
	Fri, Nov 15, 12:29 AM

	Unknown Object (File)
	Sun, Nov 3, 7:45 PM

	Unknown Object (File)
	Sun, Nov 3, 12:36 AM

	Unknown Object (File)
	Sun, Nov 3, 12:35 AM

	Unknown Object (File)
	Sun, Nov 3, 12:30 AM

	Unknown Object (File)
	Sep 26 2024, 10:16 PM

	Unknown Object (File)
	Sep 26 2024, 10:16 PM

	Unknown Object (File)
	Sep 26 2024, 10:13 PM

Subscribers

Details

Reviewers

kamil
• jon

Summary

Depends on D5440

Test Plan

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Oct 20 2022, 8:59 AM

Herald added a reviewer: • jon. · View Herald TranscriptOct 20 2022, 8:59 AM

Herald added subscribers: • abosh, tomek, ashoat. · View Herald Transcript

atul published this revision for review.Oct 20 2022, 9:00 AM

atul mentioned this in D5377: [native/sqlite] refactor code to perform migration inside one transaction.

Harbormaster failed remote builds in B12935: Diff 17734!Oct 20 2022, 9:05 AM

Harbormaster completed remote builds in B12935: Diff 17734.Oct 20 2022, 10:40 AM

• jon added inline comments.Oct 21 2022, 12:01 PM

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
570–572	seems a little odd to me, lines 557-559 should iterate to the next applicable migration. This logic seems like it would be really error prone and a source of constant pain later on.

This was only ever meant as a demonstration

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

DatabaseManagers/

SQLiteQueryExecutor.cpp

8 lines

Diff 17734

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

[IGNORE][CommCoreModule] `ROLLBACK` if migration idx <= db_version_inside_transactionAbandonedPublicActions