[native] fix path to native rust library directory
ClosedPublic
Actions

Authored by varun on Oct 25 2022, 12:10 PM.

Details

Reviewers

atul
• jon
• max

Commits

rCOMM8687152bd65c: [native] fix path to native rust library directory

Summary

We were incorrectly including a directory containing build artifacts from a previous Xcode build. This happened to work by coincidence, but is not the right directory. Now we include the directory created by corrosion containing the correct native_rust_library source files.

Test Plan

cd native/android && ./gradlew bundleDebug && ./gradlew bundleRelease

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Oct 25 2022, 12:10 PM

Herald added subscribers: • abosh, tomek, ashoat. · View Herald TranscriptOct 25 2022, 12:10 PM

I cherry-picked this change to D5369 and it worked locally

Added @jon as a reviewer because I'm not sure if there's a more idiomatic way to do this

Harbormaster completed remote builds in B13037: Diff 17906.Oct 25 2022, 12:23 PM

varun requested review of this revision.Oct 25 2022, 12:23 PM

Pre-empting any future CI issues because of case-sensitivity on certain platforms

Harbormaster completed remote builds in B13040: Diff 17909.Oct 25 2022, 12:56 PM

• max accepted this revision.Oct 25 2022, 4:46 PM

• max added inline comments.

native/android/app/CMakeLists.txt
134	Looks monstrous, but seems we can't get rid of this.

atul accepted this revision.Oct 26 2022, 10:29 AM

atul added inline comments.

native/android/app/CMakeLists.txt
134	+1

This revision is now accepted and ready to land.Oct 26 2022, 10:29 AM

I want to make sure @jon takes a look since he's the in-house CMake expert

This revision now requires review to proceed.Oct 26 2022, 11:14 AM

• jon accepted this revision.Oct 26 2022, 12:02 PM

• jon added inline comments.

native/android/app/CMakeLists.txt
134	If this path is generated at build time, using `${CMAKE_CURRENT_BINARY_DIR}/.cxx` is probably the best practice. This should only make a difference if we do `add_subdirectory(native/android/app)`. But it's just avoid that potential pain.