as per title we're moving the public_key to the cookies column so i dropped those columns from users and sessions.
linear task
another linear task
Details
Details
run the migration script & watch some columns disappear
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- derek/keyserver
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
we're moving the public_key to the cookies column
Is this value empty for all the existing rows? If that's not the case, we should migrate it, but otherwise we're fine.
run the migration script & watch some columns disappear
How did you run the script? Was it manually or automatically?
Also, the test plan should include a check of creating a new database - after uninstalling the app.
| keyserver/src/database/migration-config.js | ||
|---|---|---|
| 55–56 ↗ | (On Diff #17960) | Why do we use semicolon after every line? Is it a correct syntax? In other ALTER TABLE statements we're using commas to separate. |
| keyserver/src/database/migration-config.js | ||
|---|---|---|
| 55–56 ↗ | (On Diff #17960) | I suspect this is invalid syntax, which makes me question whether it was tested at all... |
| keyserver/src/database/migration-config.js | ||
|---|---|---|
| 55–56 ↗ | (On Diff #17960) | my mistake, i had merge conflicts when i rebased & i must've missed this |