Page MenuHomePhabricator

[services] Tunnelbroker - Removing of emptiness check for notification token
ClosedPublic

Authored by max on Nov 4 2022, 9:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 7, 8:41 AM
Unknown Object (File)
Fri, Oct 25, 10:09 PM
Unknown Object (File)
Oct 6 2024, 1:03 PM
Unknown Object (File)
Oct 6 2024, 1:43 AM
Unknown Object (File)
Oct 6 2024, 1:09 AM
Unknown Object (File)
Oct 6 2024, 1:07 AM
Unknown Object (File)
Oct 2 2024, 7:53 PM
Unknown Object (File)
Sep 26 2024, 9:59 PM

Details

Summary

In this diff, we are removing the database item internal check for the device's notification token field.
We are fixing the bug where the database error occurs in the case when the device token in the database became empty and the server will return a database error when retrieving the token in the next client connection.

The field can be empty and the database check shouldn't fail on this. For more context please refer to the D5536.

Linear task: ENG-2060

Test Plan

This is a legacy C++ codebase change, the expected successful result is the successful building of the app and passing the CI checks.

Diff Detail

Repository
rCOMM Comm
Branch
fix-removing-empty-check-for-token
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

max held this revision as a draft.
max edited the test plan for this revision. (Show Details)
max added a reviewer: tomek.
max edited the summary of this revision. (Show Details)
max published this revision for review.Nov 4 2022, 9:57 AM
This revision is now accepted and ready to land.Nov 7 2022, 1:54 AM

Rebasing on master changes and merging.