Paths

Table of Contentst

[services] Tunnelbroker - Adding of `constants.rs` file
ClosedPublic
Actions

Authored by • max on Nov 2 2022, 2:23 PM.

Details

Reviewers

• jon
marcin
tomek

Commits

rCOMM92eed993799d: [services] Tunnelbroker - Adding of `constants.rs` file

Summary

Following the current codebase approach, this diff introduces the constants.rs file which will contain global constants.
The currently added constants are:

GRPC_TX_QUEUE_SIZE - The gRPC stream queue size. Used in D5529.
GRPC_PING_INTERVAL_MS - Client pinging interval. Used in D5529.

Linear task: ENG-1247

Test Plan

Passing the build tests in D5529.

Diff Detail

Repository

rCOMM Comm

Branch

D5526

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Nov 2 2022, 2:23 PM

• max held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptNov 2 2022, 2:23 PM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript

• max added a parent revision: D5490: [services] Tunnelbroker - Adding of gRPC `NewSession` wrapper implementation.Nov 2 2022, 2:24 PM

• max added a child revision: D5527: [services] Tunnelbroker - Adding `tokio-stream` dependency to the Cargo.Nov 2 2022, 2:34 PM

Harbormaster completed remote builds in B13145: Diff 18040.Nov 2 2022, 2:35 PM

• max published this revision for review.Nov 2 2022, 4:38 PM

• max edited the summary of this revision. (Show Details)

• max edited the test plan for this revision. (Show Details)

• max added a reviewer: marcin. • max added 1 blocking reviewer(s): • jon.

• max added inline comments.

services/tunnelbroker/src/main.rs
1 ↗	(On Diff #18040)	We should add this as a `mod` into the main to use it as `super::constants` later in D5529.

• jon accepted this revision.Nov 3 2022, 10:04 AM

This revision is now accepted and ready to land.Nov 3 2022, 10:04 AM

• max added a reviewer: tomek.Nov 3 2022, 10:25 AM

This revision now requires review to proceed.Nov 3 2022, 10:25 AM

tomek accepted this revision.Nov 4 2022, 7:30 AM

This revision is now accepted and ready to land.Nov 4 2022, 7:30 AM

Rebasing on master changes.

• max removed a parent revision: D5490: [services] Tunnelbroker - Adding of gRPC `NewSession` wrapper implementation.Nov 7 2022, 9:15 AM

• max removed a child revision: D5527: [services] Tunnelbroker - Adding `tokio-stream` dependency to the Cargo.

Harbormaster failed remote builds in B13222: Diff 18146!Nov 7 2022, 9:24 AM

This revision was landed with ongoing or failed builds.Nov 7 2022, 9:44 AM

Closed by commit rCOMM92eed993799d: [services] Tunnelbroker - Adding of `constants.rs` file (authored by • max). · Explain Why

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMM92eed993799d: [services] Tunnelbroker - Adding of `constants.rs` file.

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

constants.rs

2 lines

main.rs

2 lines

Diff 18146

View Options

services/tunnelbroker/src/constants.rs