Page MenuHomePhabricator
Differential D5527

[services] Tunnelbroker - Adding `tokio-stream` dependency to the Cargo
ClosedPublic
Actions

Authored by • max on Nov 2 2022, 2:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 3:10 AM
Unknown Object (File)
Mon, Mar 17, 3:10 AM
Unknown Object (File)
Mon, Mar 17, 3:10 AM
Unknown Object (File)
Mon, Mar 17, 3:09 AM
Unknown Object (File)
Mon, Mar 17, 3:04 AM
Unknown Object (File)
Tue, Mar 4, 11:22 PM
Unknown Object (File)
Feb 17 2025, 3:42 PM
Unknown Object (File)
Feb 13 2025, 9:18 AM
View All Files
Subscribers
• abosh
ashoat
atul
tomek

Details

Reviewers
• jon
marcin
varun
ashoat
Commits
rCOMM597fa55ea368: [services] Tunnelbroker - Adding `tokio-stream` dependency to the Cargo
Summary

This diff adds the tokio-stream crate as a dependency.
We are using tokio_stream::wrappers in the following D5528 diff to wrap the streams and bind them to the tokio::sync::mpsc queue to iterate over it.

Linear task: ENG-2060

Test Plan

Service is successfully built in the following D5528 using this crate.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• max created this revision.Nov 2 2022, 2:34 PM
• max held this revision as a draft.
Herald added a reviewer: • jon. · View Herald TranscriptNov 2 2022, 2:34 PM
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript
• max added a parent revision: D5526: [services] Tunnelbroker - Adding of `constants.rs` file.Nov 2 2022, 2:34 PM
Harbormaster completed remote builds in B13146: Diff 18041.Nov 2 2022, 2:45 PM
• max added a child revision: D5528: [services] Tunnelbroker - Adding of the client authentication by the `sessionID` from metadata.Nov 2 2022, 2:50 PM
• max published this revision for review.Nov 3 2022, 5:33 AM
• max edited the summary of this revision. (Show Details)
• max edited the test plan for this revision. (Show Details)
• max added reviewers: marcin, varun. • max added 1 blocking reviewer(s): • jon.
• max edited the summary of this revision. (Show Details)
• jon accepted this revision.Nov 3 2022, 10:03 AM
This revision is now accepted and ready to land.Nov 3 2022, 10:03 AM
• max added a reviewer: ashoat.Nov 3 2022, 10:26 AM
This revision now requires review to proceed.Nov 3 2022, 10:26 AM
ashoat accepted this revision.Nov 3 2022, 12:26 PM
This revision is now accepted and ready to land.Nov 3 2022, 12:26 PM
• max removed a parent revision: D5526: [services] Tunnelbroker - Adding of `constants.rs` file.Nov 7 2022, 9:16 AM
• max removed a child revision: D5528: [services] Tunnelbroker - Adding of the client authentication by the `sessionID` from metadata.
• max updated this revision to Diff 18153.Nov 7 2022, 9:42 AM

Rebasing on master changes.

Harbormaster failed remote builds in B13229: Diff 18153!Nov 7 2022, 9:44 AM
Harbormaster completed remote builds in B13229: Diff 18153.Nov 7 2022, 9:57 AM
Closed by commit rCOMM597fa55ea368: [services] Tunnelbroker - Adding `tokio-stream` dependency to the Cargo (authored by • max). · Explain WhyNov 7 2022, 10:01 AM
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMM597fa55ea368: [services] Tunnelbroker - Adding `tokio-stream` dependency to the Cargo.

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
1 line

Diff 18155

View Options

services/tunnelbroker/Cargo.lock

Show First 20 Lines • Show All 191 Lines • ▼ Show 20 Lines if (messagesFromDatabase.size() > 0) {
// if there are undelivered messages in the database. If so, we are // if there are undelivered messages in the database. If so, we are
// erasing the messages to deliver from rabbitMQ which are handled by // erasing the messages to deliver from rabbitMQ which are handled by
// DeliveryBroker. // DeliveryBroker.
DeliveryBroker::getInstance().erase(clientDeviceID); DeliveryBroker::getInstance().erase(clientDeviceID);
} }
tunnelbroker::GetResponse response; tunnelbroker::GetResponse response;
auto respondToWriter = auto respondToWriter =
[&writer, &response](std::string fromDeviceID, std::string payload) { [&writer, &response](std::string fromDeviceID, std::string payload) {
response.set_fromdeviceid(fromDeviceID); response.mutable_responsemessage()->set_fromdeviceid(fromDeviceID);
response.set_payload(payload); response.mutable_responsemessage()->set_payload(payload);
if (!writer->Write(response)) { if (!writer->Write(response)) {
throw std::runtime_error( throw std::runtime_error(
"gRPC: 'Get' writer error on sending data to the client"); "gRPC: 'Get' writer error on sending data to the client");
} }
response.Clear(); response.Clear();
}; };
for (auto &messageFromDatabase : messagesFromDatabase) { for (auto &messageFromDatabase : messagesFromDatabase) {
respondToWriter( respondToWriter(
Show All 28 Lines
View Options

services/tunnelbroker/Cargo.toml

Show First 20 Lines • Show All 191 Lines • ▼ Show 20 Lines if (messagesFromDatabase.size() > 0) {
// if there are undelivered messages in the database. If so, we are // if there are undelivered messages in the database. If so, we are
// erasing the messages to deliver from rabbitMQ which are handled by // erasing the messages to deliver from rabbitMQ which are handled by
// DeliveryBroker. // DeliveryBroker.
DeliveryBroker::getInstance().erase(clientDeviceID); DeliveryBroker::getInstance().erase(clientDeviceID);
} }
tunnelbroker::GetResponse response; tunnelbroker::GetResponse response;
auto respondToWriter = auto respondToWriter =
[&writer, &response](std::string fromDeviceID, std::string payload) { [&writer, &response](std::string fromDeviceID, std::string payload) {
response.set_fromdeviceid(fromDeviceID); response.mutable_responsemessage()->set_fromdeviceid(fromDeviceID);
response.set_payload(payload); response.mutable_responsemessage()->set_payload(payload);
if (!writer->Write(response)) { if (!writer->Write(response)) {
throw std::runtime_error( throw std::runtime_error(
"gRPC: 'Get' writer error on sending data to the client"); "gRPC: 'Get' writer error on sending data to the client");
} }
response.Clear(); response.Clear();
}; };
for (auto &messageFromDatabase : messagesFromDatabase) { for (auto &messageFromDatabase : messagesFromDatabase) {
respondToWriter( respondToWriter(
Show All 28 Lines