Paths

Table of Contentst

[services] Tunnelbroker - Adding `tokio-stream` dependency to the Cargo
ClosedPublic
Actions

Authored by • max on Nov 2 2022, 2:34 PM.

Details

Reviewers

• jon
marcin
varun
ashoat

Commits

rCOMM597fa55ea368: [services] Tunnelbroker - Adding `tokio-stream` dependency to the Cargo

Summary

This diff adds the tokio-stream crate as a dependency.
We are using tokio_stream::wrappers in the following D5528 diff to wrap the streams and bind them to the tokio::sync::mpsc queue to iterate over it.

Linear task: ENG-2060

Test Plan

Service is successfully built in the following D5528 using this crate.

Diff Detail

Repository

rCOMM Comm

Branch

add-tokio-stream-to-cargo

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Nov 2 2022, 2:34 PM

• max held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptNov 2 2022, 2:34 PM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript

• max added a parent revision: D5526: [services] Tunnelbroker - Adding of `constants.rs` file.Nov 2 2022, 2:34 PM

Harbormaster completed remote builds in B13146: Diff 18041.Nov 2 2022, 2:45 PM

• max added a child revision: D5528: [services] Tunnelbroker - Adding of the client authentication by the `sessionID` from metadata.Nov 2 2022, 2:50 PM

• max published this revision for review.Nov 3 2022, 5:33 AM

• max edited the summary of this revision. (Show Details)

• max edited the test plan for this revision. (Show Details)

• max added reviewers: marcin, varun. • max added 1 blocking reviewer(s): • jon.

• max edited the summary of this revision. (Show Details)

• jon accepted this revision.Nov 3 2022, 10:03 AM

This revision is now accepted and ready to land.Nov 3 2022, 10:03 AM

• max added a reviewer: ashoat.Nov 3 2022, 10:26 AM

This revision now requires review to proceed.Nov 3 2022, 10:26 AM

ashoat accepted this revision.Nov 3 2022, 12:26 PM

This revision is now accepted and ready to land.Nov 3 2022, 12:26 PM

• max removed a parent revision: D5526: [services] Tunnelbroker - Adding of `constants.rs` file.Nov 7 2022, 9:16 AM

• max removed a child revision: D5528: [services] Tunnelbroker - Adding of the client authentication by the `sessionID` from metadata.

Rebasing on master changes.

Harbormaster failed remote builds in B13229: Diff 18153!Nov 7 2022, 9:44 AM

Harbormaster completed remote builds in B13229: Diff 18153.Nov 7 2022, 9:57 AM

Closed by commit rCOMM597fa55ea368: [services] Tunnelbroker - Adding `tokio-stream` dependency to the Cargo (authored by • max). · Explain WhyNov 7 2022, 10:01 AM

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMM597fa55ea368: [services] Tunnelbroker - Adding `tokio-stream` dependency to the Cargo.

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

Cargo.lock

Cargo.toml

1 line

Diff 18041

View Options

services/tunnelbroker/Cargo.lock