[native] introduced flow type for reanimated layout animations
ClosedPublic
Actions

Authored by ginsu on Nov 8 2022, 8:22 AM.

Details

Reviewers

atul
ashoat

Commits

rCOMM032ab74877db: [native] introduced flow type for reanimated layout animations

Summary

To use Reanimated's new layout animations we need to add libdefs for the different animations. This diff just handles the SlideInDown and SlideOutDown layout animations along with all the necessary classes/types needed to support these layout animations. I will annotate inline with where the changes/types came from.

Linear Task: ENG-2165

Test Plan

All the testing for this diff came from its use in D5557. In that diff I was able to implement the layout actions using the appropriate type defs that I created in this diff, and I received no flow errors which I believe to be a good indicator that everything is correct.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Nov 8 2022, 8:22 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptNov 8 2022, 8:22 AM

ginsu edited the summary of this revision. (Show Details)Nov 8 2022, 8:29 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, ashoat.

Harbormaster completed remote builds in B13269: Diff 18211.Nov 8 2022, 8:32 AM

ginsu requested review of this revision.Nov 8 2022, 8:32 AM

ginsu planned changes to this revision.Nov 8 2022, 8:34 AM

ginsu added inline comments.

native/flow-typed/npm/react-native-reanimated_v2.x.x.js
18–36 ↗	(On Diff #18211)	bottom-tabs_v6
146 ↗	(On Diff #18211)	reanimated easing

made LayoutAnimation type exact

Looks good to me, would love if @atul could take a look as well

need to fix prettier format change

resoved prettier problem

Harbormaster completed remote builds in B13273: Diff 18215.Nov 8 2022, 8:50 AM

Harbormaster completed remote builds in B13274: Diff 18216.Nov 8 2022, 8:54 AM

ginsu added inline comments.Nov 8 2022, 9:35 AM

native/flow-typed/npm/react-native-reanimated_v2.x.x.js
18–36 ↗	(On Diff #18216)	bottom-tabs_v6
146 ↗	(On Diff #18216)	reanimated easing
237–312 ↗	(On Diff #18216)	reanimated common types
314–336 ↗	(On Diff #18216)	reanimated BaseAnimationBuilder
342–382 ↗	(On Diff #18216)	reanimated ComplexAnimationBuilder
384–388 ↗	(On Diff #18216)	reanimated slideindown
390–394 ↗	(On Diff #18216)	reanimated slideoutdown