Page MenuHomePhabricator
Differential D5568

[services][identity] helper function to parse map attributes from dynamodb
ClosedPublic
Actions

Authored by varun on Nov 8 2022, 1:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 7:23 AM
Unknown Object (File)
Tue, Dec 17, 7:23 AM
Unknown Object (File)
Tue, Dec 17, 7:22 AM
Unknown Object (File)
Tue, Dec 17, 7:19 AM
Unknown Object (File)
Sat, Dec 7, 7:46 PM
Unknown Object (File)
Oct 25 2024, 5:18 PM
Unknown Object (File)
Oct 25 2024, 5:18 PM
Unknown Object (File)
Oct 25 2024, 5:17 PM
View All 61 Files
Subscribers
• abosh
ashoat
atul

Details

Reviewers
tomek
bartek
• jon
Commits
rCOMM69c5110d43e7: [services][identity] helper function to parse map attributes from dynamodb
Summary

fairly straightforward. we take an Option<AttributeValue> that should hold a HashMap and then return the HashMap or an error if it's the wrong type or missing

Depends on D5567

Test Plan

this helper function is tested two diffs later when the getUserPublicKey RPC is actual callable

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Nov 8 2022, 1:13 PM
Herald added a reviewer: • jon. · View Herald TranscriptNov 8 2022, 1:13 PM
Herald added subscribers: • abosh, atul, ashoat. · View Herald Transcript
varun added a child revision: D5569: [services][identity] db client method to get user public key.Nov 8 2022, 1:13 PM
Harbormaster completed remote builds in B13291: Diff 18235.Nov 8 2022, 1:26 PM
varun requested review of this revision.Nov 8 2022, 1:26 PM
varun added a child revision: D5572: [services][identity] helper function to get item from users table.Nov 8 2022, 2:51 PM
varun removed a child revision: D5569: [services][identity] db client method to get user public key.Nov 8 2022, 2:54 PM
• jon accepted this revision.Nov 9 2022, 11:07 AM
bartek accepted this revision.Nov 9 2022, 12:46 PM
tomek accepted this revision.Nov 10 2022, 2:02 AM
This revision is now accepted and ready to land.Nov 10 2022, 2:02 AM
tomek added inline comments.Nov 10 2022, 2:13 AM
services/identity/src/database.rs
518

Why do we use devices name here? This function seems like something more general and the name should reflect that.

varun added inline comments.Nov 10 2022, 8:25 AM
services/identity/src/database.rs
518

yeah good catch, i'll change that before landing

Closed by commit rCOMM69c5110d43e7: [services][identity] helper function to parse map attributes from dynamodb (authored by varun). · Explain WhyNov 10 2022, 12:41 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM69c5110d43e7: [services][identity] helper function to parse map attributes from dynamodb.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
19 lines

Diff 18235

View Options

services/identity/src/database.rs

Loading...