[services][identity] db client method to get user public key
ClosedPublic
Actions

Authored by varun on Nov 8 2022, 1:13 PM.

Details

Reviewers

tomek
bartek
• jon

Commits

rCOMM16e3eb00236b: [services][identity] db client method to get user public key

Summary

first we use the user ID to get the associated item from the users table in DDB. then we try to find the device ID in the item's devices map, and if successful, return the device's user public key.

Depends on D5568

Test Plan

tested in the next diff when the getUserPublicKey RPC is callable

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Nov 8 2022, 1:13 PM

Herald added a reviewer: • jon. · View Herald TranscriptNov 8 2022, 1:13 PM

Herald added subscribers: • abosh, atul, ashoat. · View Herald Transcript

varun added a child revision: D5570: [services][identity] implement get_user_public_key service method.Nov 8 2022, 1:16 PM

Harbormaster completed remote builds in B13292: Diff 18236.Nov 8 2022, 1:27 PM

varun requested review of this revision.Nov 8 2022, 1:27 PM

rebase

varun edited parent revisions, added: D5572: [services][identity] helper function to get item from users table; removed: D5568: [services][identity] helper function to parse map attributes from dynamodb.Nov 8 2022, 2:54 PM

Harbormaster completed remote builds in B13296: Diff 18240.Nov 8 2022, 3:07 PM

• jon added inline comments.Nov 9 2022, 11:13 AM

services/identity/src/database.rs
335	why do we remove the item as part of parsing the attribute? seems a bit odd to be mutating a collection while searching through them.

varun added inline comments.Nov 9 2022, 11:20 AM

services/identity/src/database.rs
335		`get` only returns a reference to the item, whereas `remove` returns the actual value. this lets us avoid cloning
325–340 ↗	(On Diff #18236)	https://linear.app/comm/issue/ENG-2204/create-helper-function-for-getting-item-from-users-table-in-ddb

tomek accepted this revision.Nov 10 2022, 4:48 AM

tomek added inline comments.

services/identity/src/database.rs
335	I'm not convinced that using confusing method is a good solution to work around borrowing issues. How the code would look like if we used `get` method?

This revision is now accepted and ready to land.Nov 10 2022, 4:48 AM

varun added inline comments.Nov 10 2022, 12:37 PM

services/identity/src/database.rs
335	i don't really think it's confusing, and it seems like a common practice. jim was actually the one who suggested it a while ago. if we use the `get` method we have to clone the borrowed value. we use `remove` a lot in this module already, but i'm happy to change them to `get`s if you guys think that's better.