Page MenuHomePhabricator
Differential D5583

[web] Change alert type in UserListItem
AbandonedPublic
Actions

Authored by • kuba on Nov 9 2022, 5:42 AM.
Tags
None
Referenced Files
F3391612: D5583.id18266.diff
Sat, Nov 30, 4:53 AM
F3391559: D5583.id23050.diff
Sat, Nov 30, 4:40 AM
F3391548: D5583.id23148.diff
Sat, Nov 30, 4:38 AM
F3391517: D5583.id23222.diff
Sat, Nov 30, 4:27 AM
Unknown Object (File)
Thu, Nov 21, 3:19 PM
Unknown Object (File)
Mon, Nov 18, 7:03 PM
Unknown Object (File)
Sat, Nov 9, 9:32 PM
Unknown Object (File)
Fri, Nov 8, 8:10 PM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
atul
• abosh
ginsu
rohan
michal
Summary

Raised in D5518, it doesn't make sense for only one of alertText and alertTitle to be defined. This diff changes the type to make sure they are always defined together and updates the usages.

Depends on D5463

Test Plan

Check for flow errors. Check if thread composer works correctly on web and native

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

michal created this revision.Nov 9 2022, 5:42 AM
michal added a child revision: D5518: [web] Unify behaviour of chat composer with native.Nov 9 2022, 5:43 AM
Harbormaster completed remote builds in B13316: Diff 18266.Nov 9 2022, 5:56 AM
michal requested review of this revision.Nov 9 2022, 5:56 AM
atul added reviewers: ginsu, rohan.Nov 9 2022, 12:42 PM
tomek accepted this revision.Nov 10 2022, 5:46 AM
tomek added inline comments.
lib/types/user-types.js
75–76

These two should be read only

This revision is now accepted and ready to land.Nov 10 2022, 5:46 AM
• kuba commandeered this revision.Feb 22 2023, 6:06 AM
• kuba added a reviewer: michal.
• kuba updated this revision to Diff 22967.Feb 23 2023, 1:12 AM

Rebase v3

Harbormaster failed remote builds in B16798: Diff 22967!Feb 23 2023, 1:27 AM
• kuba updated this revision to Diff 22970.Feb 23 2023, 1:31 AM

Updated parent - rebase

Harbormaster completed remote builds in B16801: Diff 22970.Feb 23 2023, 1:45 AM
• kuba updated this revision to Diff 23050.Feb 24 2023, 3:46 AM

Rebase - parent update

Harbormaster completed remote builds in B16871: Diff 23050.Feb 24 2023, 4:01 AM
• kuba updated this revision to Diff 23148.Feb 27 2023, 4:32 AM

Rebase

Harbormaster completed remote builds in B16936: Diff 23148.Feb 27 2023, 4:48 AM
• kuba updated this revision to Diff 23220.Feb 28 2023, 3:17 AM

Rebase

• kuba updated this revision to Diff 23222.Feb 28 2023, 3:23 AM

Another try to fix rebasing

Harbormaster completed remote builds in B16981: Diff 23220.Feb 28 2023, 3:33 AM
Harbormaster completed remote builds in B16983: Diff 23222.Feb 28 2023, 3:38 AM
• kuba mentioned this in D8223: [web] Change alert type in UserListItem.Jun 15 2023, 1:20 AM
• kuba abandoned this revision.Jun 15 2023, 1:22 AM

New version in a new stack: https://phab.comm.dev/D8223

kosmydel <kukubaczek@gmail.com> mentioned this in rCOMMb163ec8ca4f3: [web] Change alert type in UserListItem.Jun 21 2023, 1:01 AM

Revision Contents
Changeset List

PathSize
lib/
shared/
42 lines
types/
6 lines
native/
chat/
2 lines
components/
4 lines
web/
chat/
4 lines
modals/
components/
6 lines
threads/
members/
4 lines

Diff 18266

View Options

lib/shared/search-utils.js

Loading...
View Options

lib/types/user-types.js

Loading...
View Options

native/chat/message-list-thread-search.react.js

Loading...
View Options

native/components/user-list-user.react.js

Loading...
View Options

web/chat/chat-thread-composer.react.js

Loading...
View Options

web/modals/components/add-members-item.react.js

Loading...
View Options

web/modals/threads/members/add-members-list-content.react.js

Loading...