Page MenuHomePhabricator
Differential D5587

[native] Pull `useIsCurrentUserStaff()` out of `useStaffCanSee()`
ClosedPublic
Actions

Authored by atul on Nov 9 2022, 12:39 PM.
Tags
None
Referenced Files
F3251853: D5587.id18293.diff
Fri, Nov 15, 5:56 PM
F3251442: D5587.id18325.diff
Fri, Nov 15, 5:34 PM
F3249540: D5587.diff
Fri, Nov 15, 3:54 PM
Unknown Object (File)
Thu, Nov 14, 11:22 AM
Unknown Object (File)
Sat, Nov 2, 8:14 PM
Unknown Object (File)
Sat, Nov 2, 8:14 PM
Unknown Object (File)
Sat, Nov 2, 8:14 PM
Unknown Object (File)
Sat, Nov 2, 8:14 PM
View All 76 Files
Subscribers
• abosh
ashoat

Details

Reviewers
tomek
marcin
varun
ginsu
rohan
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rCOMMd8ff5dff6040: [native] Pull `useIsCurrentUserStaff()` out of `useStaffCanSee()`
Summary

Pull useIsCurrentUserStaff() out from useStaffCanSee() and consume in BuildInfo and StaffContextProvider.

Test Plan

BuildInfo + StaffContextProvider continue to look/work as expected.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Nov 9 2022, 12:39 PM
Herald added subscribers: • abosh, ashoat. · View Herald TranscriptNov 9 2022, 12:39 PM
atul added 2 blocking reviewer(s): ginsu, rohan.Nov 9 2022, 12:41 PM
atul mentioned this in D5558: [native] Include additional fields in `BuildInfo`.Nov 9 2022, 12:45 PM
atul published this revision for review.Nov 9 2022, 12:49 PM
Harbormaster completed remote builds in B13341: Diff 18293.Nov 9 2022, 12:53 PM
atul removed 2 blocking reviewer(s): ginsu, rohan.Nov 9 2022, 7:29 PM
atul added a reviewer: Restricted Owners Package.Nov 10 2022, 5:54 AM
tomek accepted this revision.Nov 10 2022, 7:55 AM
This revision is now accepted and ready to land.Nov 10 2022, 7:55 AM
atul updated this revision to Diff 18325.Nov 10 2022, 9:34 AM

rebase before landing

This revision was landed with ongoing or failed builds.Nov 10 2022, 9:35 AM
Closed by commit rCOMMd8ff5dff6040: [native] Pull `useIsCurrentUserStaff()` out of `useStaffCanSee()` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMd8ff5dff6040: [native] Pull `useIsCurrentUserStaff()` out of `useStaffCanSee()`.
Harbormaster completed remote builds in B13366: Diff 18325.Nov 10 2022, 9:49 AM

Revision Contents
Changeset List

PathSize
native/
profile/
16 lines
staff/
11 lines
utils/
9 lines

Diff 18293

View Options

native/profile/build-info.react.js

Loading...
View Options

native/staff/staff-context.provider.react.js

Loading...
View Options

native/utils/staff-utils.js

Loading...