[native] Update `listChatBubble` for light mode
ClosedPublic
Actions

Authored by atul on Nov 10 2022, 6:04 PM.

Details

Reviewers

tomek
marcin
ginsu
rohan
• abosh
varun
ashoat

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rCOMMaabfb68826c2: [native] Update `listChatBubble` for light mode

Summary

Context: https://linear.app/comm/issue/ENG-2052/re-introduce-light-mode-in-native

Test Plan

Before:

After:

Things look as expected.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Nov 10 2022, 6:04 PM

Herald added a subscriber: ashoat. · View Herald TranscriptNov 10 2022, 6:04 PM

atul edited the test plan for this revision. (Show Details)Nov 10 2022, 6:05 PM

Harbormaster completed remote builds in B13393: Diff 18368.Nov 10 2022, 6:18 PM

atul requested review of this revision.Nov 10 2022, 6:18 PM

The new shade definitely looks better in my opinion

This revision is now accepted and ready to land.Nov 11 2022, 8:08 AM

atul added a reviewer: Restricted Owners Package.Nov 11 2022, 8:22 AM

This revision now requires review to proceed.Nov 11 2022, 8:22 AM

love it

ashoat accepted this revision.Nov 11 2022, 1:00 PM

This revision is now accepted and ready to land.Nov 11 2022, 1:00 PM

Closed by commit rCOMMaabfb68826c2: [native] Update `listChatBubble` for light mode (authored by atul). · Explain WhyNov 11 2022, 1:09 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMaabfb68826c2: [native] Update `listChatBubble` for light mode.

Revision Contents
Changeset List

Path

Size

native/

themes/

colors.js

2 lines

Diff 18386

View Options

[native] Update `listChatBubble` for light modeClosedPublicActions