Page MenuHomePhabricator
Differential D5619

[native] Fix appearance of `ColorSelectorModal` in light mode
ClosedPublic
Actions

Authored by atul on Nov 11 2022, 2:19 PM.
Tags
None
Referenced Files
F2895400: D5619.diff
Fri, Oct 4, 5:59 PM
Unknown Object (File)
Wed, Sep 11, 12:59 AM
Unknown Object (File)
Wed, Sep 11, 12:59 AM
Unknown Object (File)
Wed, Sep 11, 12:59 AM
Unknown Object (File)
Wed, Sep 11, 12:58 AM
Unknown Object (File)
Thu, Sep 5, 5:29 AM
Unknown Object (File)
Thu, Sep 5, 5:29 AM
Unknown Object (File)
Sep 1 2024, 11:08 PM
View All 88 Files
Subscribers
• abosh
ashoat

Details

Reviewers
tomek
marcin
ginsu
rohan
ashoat
Commits
rCOMM38f16638f790: [native] Fix appearance of `ColorSelectorModal` in light mode
Summary

Context: https://linear.app/comm/issue/ENG-2052/re-introduce-light-mode-in-native

Test Plan

Before:

Simulator Screen Shot - iPhone 14 Pro - 2022-11-11 at 17.17.26.png (2×1 px, 175 KB)

After:

Simulator Screen Shot - iPhone 14 Pro - 2022-11-11 at 17.17.17.png (2×1 px, 177 KB)

Things look as expected (on dark mode as well).

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Nov 11 2022, 2:19 PM
Herald added subscribers: • abosh, ashoat. · View Herald TranscriptNov 11 2022, 2:19 PM
atul published this revision for review.Nov 11 2022, 2:20 PM
atul edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B13405: Diff 18389.Nov 11 2022, 2:33 PM
ashoat accepted this revision.Nov 12 2022, 6:41 AM
This revision is now accepted and ready to land.Nov 12 2022, 6:41 AM
Closed by commit rCOMM38f16638f790: [native] Fix appearance of `ColorSelectorModal` in light mode (authored by atul). · Explain WhyNov 14 2022, 7:38 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM38f16638f790: [native] Fix appearance of `ColorSelectorModal` in light mode.
atul added inline comments.Nov 28 2022, 11:23 PM
native/components/color-selector.react.js
85 ↗(On Diff #18413)

Well this is embarrassing/stupid... styles is a plain old StyleSheet and without useStyles "modalForegroundLabel" doesn't mean anything...

atul mentioned this in D5751: [native] Fix issue with `ColorSelector` header color.Nov 28 2022, 11:43 PM
atul mentioned this in rCOMM3c29c0069646: [native] Fix issue with `ColorSelector` header color.Nov 29 2022, 12:42 PM

Revision Contents
Changeset List

PathSize
native/
components/
13 lines
2 lines

Diff 18389

View Options

native/components/color-selector-button.react.js

Loading...
View Options

native/components/color-selector.react.js

Loading...