Page MenuHomePhabricator
Differential D5627

[lib] Add a selector for community roots
ClosedPublic
Actions

Authored by inka on Nov 14 2022, 6:09 AM.
Tags
None
Referenced Files
F6238644: D5627.diff
Thu, Apr 24, 6:35 PM
F6235088: D5627.id.diff
Thu, Apr 24, 2:03 PM
F6232168: D5627.id18407.diff
Thu, Apr 24, 10:37 AM
Unknown Object (File)
Thu, Apr 24, 6:15 AM
Unknown Object (File)
Thu, Apr 24, 5:34 AM
Unknown Object (File)
Thu, Apr 24, 3:10 AM
Unknown Object (File)
Thu, Apr 24, 2:49 AM
Unknown Object (File)
Wed, Apr 23, 5:24 PM
View All Files
Subscribers
• abosh
ashoat

Details

Reviewers
kamil
atul
bartek
tomek
Commits
rCOMM2f5b9feaccb3: [lib] Add a selector for community roots
Summary

Related Linear issue: https://linear.app/comm/issue/ENG-1881/community-navigation-drawer-on-native
Community drawer needs to know which threads are communities. For this reason I created this selector.

Test Plan

Add the following to in native/chat/message-list-container.react.js at the begining of ConnectedMessageListContainer:

const communities = useSelector(communintyThreadSelector);
for (const community of communities) {
  console.log(community.name);
}

and enter a chat. See, that community names are being logged to console (I have an artificially added second community, and both this community and GENESIS get logged).

Diff Detail

Repository
rCOMM Comm
Branch
inka/community_drawer
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Nov 14 2022, 6:09 AM
Herald added subscribers: • abosh, ashoat. · View Herald TranscriptNov 14 2022, 6:09 AM
inka updated this revision to Diff 18408.Nov 14 2022, 6:10 AM

Use the return-early pattern

ashoat added inline comments.Nov 14 2022, 6:15 AM
lib/selectors/thread-selectors.js
61 ↗(On Diff #18408)

Typo

inka updated this revision to Diff 18409.Nov 14 2022, 6:21 AM

Fix typo

inka edited the summary of this revision. (Show Details)Nov 14 2022, 6:23 AM
inka edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B13421: Diff 18407.Nov 14 2022, 6:23 AM
Harbormaster completed remote builds in B13422: Diff 18408.
inka added a comment.Nov 14 2022, 6:30 AM
This comment was removed by inka.
Harbormaster completed remote builds in B13423: Diff 18409.Nov 14 2022, 6:34 AM
inka requested review of this revision.Nov 14 2022, 6:34 AM
atul retitled this revision from [lib] Add a selector for comminity roots to [lib] Add a selector for community roots.Nov 14 2022, 5:16 PM
tomek accepted this revision.Nov 15 2022, 3:20 AM
This revision is now accepted and ready to land.Nov 15 2022, 3:20 AM
inka added a child revision: D5723: [native] Add CommunityDrawerContent.Nov 24 2022, 8:49 AM
inka updated this revision to Diff 20305.Dec 29 2022, 3:43 AM

Rebase

Harbormaster completed remote builds in B14888: Diff 20305.Dec 29 2022, 3:57 AM
Closed by commit rCOMM2f5b9feaccb3: [lib] Add a selector for community roots (authored by • InkaSokolowska). · Explain WhyDec 29 2022, 9:26 AM
This revision was automatically updated to reflect the committed changes.
• InkaSokolowska added a commit: rCOMM2f5b9feaccb3: [lib] Add a selector for community roots.

Revision Contents
Changeset List

PathSize
lib/
selectors/
18 lines

Diff 18407

View Options

lib/selectors/thread-selectors.js

Show All 19 Linesimport {
getMostRecentNonLocalMessageID, getMostRecentNonLocalMessageID,
messageKey, messageKey,
robotextForMessageInfo, robotextForMessageInfo,
sortMessageInfoList, sortMessageInfoList,
} from '../shared/message-utils.js'; } from '../shared/message-utils.js';
import { messageSpecs } from '../shared/messages/message-specs.js'; import { messageSpecs } from '../shared/messages/message-specs.js';
import { import {
getSidebarItems, getSidebarItems,
getAllInitialSidebarItems,
type SidebarItem, type SidebarItem,
} from '../shared/sidebar-item-utils.js'; } from '../shared/sidebar-item-utils.js';
import { threadInChatList, threadIsPending } from '../shared/thread-utils.js'; import { threadInChatList, threadIsPending } from '../shared/thread-utils.js';
import { messageTypes } from '../types/message-types-enum.js'; import { messageTypes } from '../types/message-types-enum.js';
import { import {
type ComposableMessageInfo, type ComposableMessageInfo,
isComposableMessageType, isComposableMessageType,
type LocalMessageInfo, type LocalMessageInfo,
▲ Show 20 Lines • Show All 51 Lines • ▼ Show 20 Linesfunction useCreateChatThreadItem(): ThreadInfo => ChatThreadItem {
const getLastUpdatedTimes = useGetLastUpdatedTimes(); const getLastUpdatedTimes = useGetLastUpdatedTimes();
return React.useCallback( return React.useCallback(
threadInfo => { threadInfo => {
const mostRecentNonLocalMessage = getMostRecentNonLocalMessageID( const mostRecentNonLocalMessage = getMostRecentNonLocalMessageID(
threadInfo.id, threadInfo.id,
messageStore, messageStore,
); );
const { lastUpdatedAtLeastTime: lastUpdatedTime } = getLastUpdatedTimes( const { lastUpdatedAtLeastTime } = getLastUpdatedTimes(
threadInfo, threadInfo,
messageStore, messageStore,
messageInfos, messageInfos,
); );
const sidebars = sidebarInfos[threadInfo.id] ?? []; const sidebars = sidebarInfos[threadInfo.id] ?? [];
const allSidebarItems = sidebars.map(sidebarInfo => ({ const lastUpdatedAtLeastTimeIncludingSidebars =
type: 'sidebar', sidebars.length > 0
...sidebarInfo, ? Math.max(lastUpdatedAtLeastTime, sidebars[0].lastUpdatedAtLeastTime)
})); : lastUpdatedAtLeastTime;
const lastUpdatedTimeIncludingSidebars =
allSidebarItems.length > 0
? Math.max(lastUpdatedTime, allSidebarItems[0].lastUpdatedTime)
: lastUpdatedTime;
const sidebarItems = getSidebarItems(allSidebarItems); const allInitialSidebarItems = getAllInitialSidebarItems(sidebars);
const sidebarItems = getSidebarItems(allInitialSidebarItems);
return { return {
type: 'chatThreadItem', type: 'chatThreadItem',
threadInfo, threadInfo,
mostRecentNonLocalMessage, mostRecentNonLocalMessage,
lastUpdatedTime, lastUpdatedTime: lastUpdatedAtLeastTime,
lastUpdatedTimeIncludingSidebars, lastUpdatedTimeIncludingSidebars:
lastUpdatedAtLeastTimeIncludingSidebars,
sidebars: sidebarItems, sidebars: sidebarItems,
}; };
}, },
[messageInfos, messageStore, sidebarInfos, getLastUpdatedTimes], [messageInfos, messageStore, sidebarInfos, getLastUpdatedTimes],
); );
} }
function useFlattenedChatListData(): $ReadOnlyArray<ChatThreadItem> { function useFlattenedChatListData(): $ReadOnlyArray<ChatThreadItem> {
▲ Show 20 Lines • Show All 488 Lines • Show Last 20 Lines