Page MenuHomePhabricator
Differential D5622

[native] Fix appearance of "Join Chat" in light mode
ClosedPublic
Actions

Authored by atul on Nov 11 2022, 3:18 PM.
Tags
None
Referenced Files
F3753355: D5622.id18392.diff
Fri, Jan 10, 1:53 AM
F3753273: D5622.id18393.diff
Fri, Jan 10, 1:31 AM
F3748597: D5622.diff
Thu, Jan 9, 8:39 PM
Unknown Object (File)
Tue, Dec 31, 11:26 PM
Unknown Object (File)
Tue, Dec 31, 11:26 PM
Unknown Object (File)
Tue, Dec 31, 11:26 PM
Unknown Object (File)
Tue, Dec 31, 11:26 PM
Unknown Object (File)
Tue, Dec 31, 11:23 PM
View All Files
Subscribers
• abosh
ashoat

Details

Reviewers
tomek
marcin
ginsu
rohan
ashoat
Commits
rCOMMb64ff5e82738: [native] Fix appearance of "Join Chat" in light mode
Summary

We actually don't want the color of the text here to change based on theme. Rather it should be determined by the threadColor behind it.

Test Plan

Things look as expected:

Before:

Simulator Screen Shot - iPhone 14 Pro - 2022-11-11 at 18.11.52.png (2×1 px, 1 MB)

After:

Simulator Screen Shot - iPhone 14 Pro - 2022-11-11 at 18.18.36.png (2×1 px, 1 MB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
chat/
20 lines

Diff 18416

View Options

native/chat/chat-input-bar.react.js

Loading...