Page MenuHomePhabricator
Differential D5645

Make sure drafts are not persisted via redux-persist but a placeholder is created upon rehydration
ClosedPublic
Actions

Authored by marcin on Nov 16 2022, 4:33 AM.
Tags
None
Referenced Files
F3360685: D5645.diff
Sun, Nov 24, 1:55 PM
Unknown Object (File)
Tue, Nov 19, 2:22 PM
Unknown Object (File)
Tue, Nov 19, 2:22 PM
Unknown Object (File)
Tue, Nov 19, 2:22 PM
Unknown Object (File)
Tue, Nov 19, 2:22 PM
Unknown Object (File)
Tue, Nov 19, 2:22 PM
Unknown Object (File)
Tue, Nov 19, 2:22 PM
Unknown Object (File)
Tue, Nov 19, 2:21 PM
View All Files
Subscribers
• abosh
ashoat

Details

Reviewers
tomek
atul
ashoat
Commits
rCOMM9cbc494fbaac: Make sure drafts are not persisted via redux-persist but a placeholder is…
Summary

This differential prevents drafts from being persisted in redux persist

Test Plan

Make sure eslint and flow do not point errors. This is trival test plan, but no other is possible before we implement relevant reducers.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-2137
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Nov 16 2022, 4:33 AM
Herald added subscribers: • abosh, ashoat. · View Herald TranscriptNov 16 2022, 4:33 AM
marcin added a parent revision: D5644: Bring drafts and related actions to redux.Nov 16 2022, 4:34 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Nov 16 2022, 4:35 AM
Harbormaster failed remote builds in B13466: Diff 18465!
marcin updated this revision to Diff 18469.Nov 16 2022, 4:41 AM

Retrigger CI

Harbormaster completed remote builds in B13470: Diff 18469.Nov 16 2022, 4:53 AM
marcin requested review of this revision.Nov 16 2022, 4:53 AM
marcin added a child revision: D5646: Implement draft reducer and use it in master reducer.Nov 16 2022, 5:07 AM
ashoat requested changes to this revision.Nov 16 2022, 7:18 PM
ashoat added inline comments.
native/redux/persist.js
422–433

Just add draftStore to the blacklist please

This revision now requires changes to proceed.Nov 16 2022, 7:18 PM
marcin updated this revision to Diff 18528.Nov 17 2022, 8:43 AM

Add draftStore to blacklist instead of using unnecessary custom trahsform

Harbormaster failed remote builds in B13519: Diff 18528!Nov 17 2022, 8:56 AM
Harbormaster completed remote builds in B13519: Diff 18528.Nov 17 2022, 9:11 AM
ashoat accepted this revision.Nov 17 2022, 9:52 AM
This revision is now accepted and ready to land.Nov 17 2022, 9:52 AM
ashoat added a comment.Nov 17 2022, 9:52 AM

On the web side, we'll want to do the opposite and add this to the whitelist

tomek accepted this revision.Nov 18 2022, 3:31 AM
marcin updated this revision to Diff 18686.Nov 21 2022, 9:33 AM

Rebase master

Harbormaster completed remote builds in B13639: Diff 18686.Nov 21 2022, 9:47 AM
marcin updated this revision to Diff 18755.Nov 23 2022, 4:52 AM

Rebase before landing

Harbormaster completed remote builds in B13689: Diff 18755.Nov 23 2022, 5:05 AM
Closed by commit rCOMM9cbc494fbaac: Make sure drafts are not persisted via redux-persist but a placeholder is… (authored by marcin). · Explain WhyNov 23 2022, 5:51 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM9cbc494fbaac: Make sure drafts are not persisted via redux-persist but a placeholder is….

Revision Contents
Changeset List

PathSize
native/
redux/
19 lines

Diff 18469

View Options

native/redux/persist.js

Loading...