Page MenuHomePhabricator
Differential D5644

Bring drafts and related actions to redux
ClosedPublic
Actions

Authored by marcin on Nov 16 2022, 4:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 3, 5:39 PM
Unknown Object (File)
Tue, Apr 1, 3:47 PM
Unknown Object (File)
Sun, Mar 16, 9:55 AM
Unknown Object (File)
Sun, Mar 16, 9:55 AM
Unknown Object (File)
Sun, Mar 16, 9:55 AM
Unknown Object (File)
Sun, Mar 16, 9:55 AM
Unknown Object (File)
Sun, Mar 16, 9:55 AM
Unknown Object (File)
Sun, Mar 16, 9:54 AM
View All Files
Subscribers
• abosh
ashoat

Details

Reviewers
tomek
atul
ashoat
Commits
rCOMM22edb962ced2: Bring drafts and related actions to redux
Summary

This differential creates a place for drafts in redux, and makes actions to handle them visible for reducers.

Test Plan

Make sure eslint and flow do not point errors.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.Nov 16 2022, 4:29 AM
Herald added subscribers: • abosh, ashoat. · View Herald TranscriptNov 16 2022, 4:29 AM
marcin added a parent revision: D5643: Introduce drafts related types and redux actions.Nov 16 2022, 4:30 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Nov 16 2022, 4:32 AM
Harbormaster failed remote builds in B13465: Diff 18464!
marcin added a child revision: D5645: Make sure drafts are not persisted via redux-persist but a placeholder is created upon rehydration.Nov 16 2022, 4:34 AM
marcin updated this revision to Diff 18468.Nov 16 2022, 4:40 AM

Fix eslint error

Harbormaster completed remote builds in B13469: Diff 18468.Nov 16 2022, 4:53 AM
marcin requested review of this revision.Nov 16 2022, 4:53 AM
ashoat requested changes to this revision.Nov 16 2022, 7:18 PM

Should not be on web

This revision now requires changes to proceed.Nov 16 2022, 7:18 PM
ashoat resigned from this revision.Nov 16 2022, 7:21 PM

Although maybe we want to add this on web? It didn't exist there before, but now that we have redux-persist on web maybe it is a good idea...

This revision now requires review to proceed.Nov 16 2022, 7:21 PM
marcin planned changes to this revision.Nov 17 2022, 2:56 AM
marcin requested review of this revision.Nov 17 2022, 8:22 AM
atul accepted this revision.Nov 17 2022, 11:42 AM

Super clean!

This revision is now accepted and ready to land.Nov 17 2022, 11:42 AM
tomek accepted this revision.Nov 18 2022, 3:27 AM
marcin updated this revision to Diff 18685.Nov 21 2022, 9:32 AM

Rebase master

Harbormaster completed remote builds in B13638: Diff 18685.Nov 21 2022, 9:46 AM
marcin updated this revision to Diff 18754.Nov 23 2022, 4:50 AM

Rebase before landing

Harbormaster completed remote builds in B13688: Diff 18754.Nov 23 2022, 5:03 AM
Closed by commit rCOMM22edb962ced2: Bring drafts and related actions to redux (authored by marcin). · Explain WhyNov 23 2022, 5:51 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM22edb962ced2: Bring drafts and related actions to redux.

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
1 line
lib/
types/
17 lines
native/
redux/
1 line
2 lines
web/
redux/
2 lines

Diff 18762

View Options

keyserver/src/responders/website-responders.js

Show All 21 Lines
a { a {
text-decoration: none; text-decoration: none;
color: #2a5db0; color: #2a5db0;
} }
img, img,
iframe { iframe {
display: block; display: block;
} }
input[type='text'], input[type='text'],
input[type='password'], input[type='password'],
textarea { textarea {
atulUnsubmitted
Not Done
Inline Actions

Moving the global input styling and moving it to the input component.

Then why are we keeping styles like border and border-radius?

Don't these styles also affect the <textarea> tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for input and another for textarea)?

atul: > Moving the global input styling and moving it to the input component. Then why are we…
benschacAuthorUnsubmitted
Done
Inline Actions

Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect textarea elements.

benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
-webkit-appearance: none;
-moz-appearance: none;
-webkit-border-radius: 0;
border: 1px solid #dddddd; border: 1px solid #dddddd;
border-radius: 1px; border-radius: 1px;
font-family: var(--font-stack); font-family: var(--font-stack);
} }
:global(#react-root) { :global(#react-root) {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
height: 100%; height: 100%;
▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines
View Options

lib/types/redux-types.js

Show All 21 Lines
a { a {
text-decoration: none; text-decoration: none;
color: #2a5db0; color: #2a5db0;
} }
img, img,
iframe { iframe {
display: block; display: block;
} }
input[type='text'], input[type='text'],
input[type='password'], input[type='password'],
textarea { textarea {
atulUnsubmitted
Not Done
Inline Actions

Moving the global input styling and moving it to the input component.

Then why are we keeping styles like border and border-radius?

Don't these styles also affect the <textarea> tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for input and another for textarea)?

atul: > Moving the global input styling and moving it to the input component. Then why are we…
benschacAuthorUnsubmitted
Done
Inline Actions

Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect textarea elements.

benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
-webkit-appearance: none;
-moz-appearance: none;
-webkit-border-radius: 0;
border: 1px solid #dddddd; border: 1px solid #dddddd;
border-radius: 1px; border-radius: 1px;
font-family: var(--font-stack); font-family: var(--font-stack);
} }
:global(#react-root) { :global(#react-root) {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
height: 100%; height: 100%;
▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines
View Options

native/redux/redux-setup.js

Show All 21 Lines
a { a {
text-decoration: none; text-decoration: none;
color: #2a5db0; color: #2a5db0;
} }
img, img,
iframe { iframe {
display: block; display: block;
} }
input[type='text'], input[type='text'],
input[type='password'], input[type='password'],
textarea { textarea {
atulUnsubmitted
Not Done
Inline Actions

Moving the global input styling and moving it to the input component.

Then why are we keeping styles like border and border-radius?

Don't these styles also affect the <textarea> tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for input and another for textarea)?

atul: > Moving the global input styling and moving it to the input component. Then why are we…
benschacAuthorUnsubmitted
Done
Inline Actions

Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect textarea elements.

benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
-webkit-appearance: none;
-moz-appearance: none;
-webkit-border-radius: 0;
border: 1px solid #dddddd; border: 1px solid #dddddd;
border-radius: 1px; border-radius: 1px;
font-family: var(--font-stack); font-family: var(--font-stack);
} }
:global(#react-root) { :global(#react-root) {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
height: 100%; height: 100%;
▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines
View Options

native/redux/state-types.js

Show All 21 Lines
a { a {
text-decoration: none; text-decoration: none;
color: #2a5db0; color: #2a5db0;
} }
img, img,
iframe { iframe {
display: block; display: block;
} }
input[type='text'], input[type='text'],
input[type='password'], input[type='password'],
textarea { textarea {
atulUnsubmitted
Not Done
Inline Actions

Moving the global input styling and moving it to the input component.

Then why are we keeping styles like border and border-radius?

Don't these styles also affect the <textarea> tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for input and another for textarea)?

atul: > Moving the global input styling and moving it to the input component. Then why are we…
benschacAuthorUnsubmitted
Done
Inline Actions

Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect textarea elements.

benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
-webkit-appearance: none;
-moz-appearance: none;
-webkit-border-radius: 0;
border: 1px solid #dddddd; border: 1px solid #dddddd;
border-radius: 1px; border-radius: 1px;
font-family: var(--font-stack); font-family: var(--font-stack);
} }
:global(#react-root) { :global(#react-root) {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
height: 100%; height: 100%;
▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines
View Options

web/redux/redux-setup.js

Loading...