Page MenuHomePhabricator
Differential D5644

Bring drafts and related actions to redux
ClosedPublic
Actions

Authored by marcin on Nov 16 2022, 4:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 8:20 AM
Unknown Object (File)
Fri, Nov 22, 8:20 AM
Unknown Object (File)
Fri, Nov 22, 8:20 AM
Unknown Object (File)
Fri, Nov 22, 8:20 AM
Unknown Object (File)
Fri, Nov 22, 8:20 AM
Unknown Object (File)
Fri, Nov 22, 8:20 AM
Unknown Object (File)
Tue, Nov 19, 2:11 PM
Unknown Object (File)
Sat, Nov 16, 5:00 AM
View All Files
Subscribers
• abosh
ashoat

Details

Reviewers
tomek
atul
ashoat
Commits
rCOMM22edb962ced2: Bring drafts and related actions to redux
Summary

This differential creates a place for drafts in redux, and makes actions to handle them visible for reducers.

Test Plan

Make sure eslint and flow do not point errors.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-2137
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Nov 16 2022, 4:29 AM
Herald added subscribers: • abosh, ashoat. · View Herald TranscriptNov 16 2022, 4:29 AM
marcin added a parent revision: D5643: Introduce drafts related types and redux actions.Nov 16 2022, 4:30 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Nov 16 2022, 4:32 AM
Harbormaster failed remote builds in B13465: Diff 18464!
marcin added a child revision: D5645: Make sure drafts are not persisted via redux-persist but a placeholder is created upon rehydration.Nov 16 2022, 4:34 AM
marcin updated this revision to Diff 18468.Nov 16 2022, 4:40 AM

Fix eslint error

Harbormaster completed remote builds in B13469: Diff 18468.Nov 16 2022, 4:53 AM
marcin requested review of this revision.Nov 16 2022, 4:53 AM
ashoat requested changes to this revision.Nov 16 2022, 7:18 PM

Should not be on web

This revision now requires changes to proceed.Nov 16 2022, 7:18 PM
ashoat resigned from this revision.Nov 16 2022, 7:21 PM

Although maybe we want to add this on web? It didn't exist there before, but now that we have redux-persist on web maybe it is a good idea...

This revision now requires review to proceed.Nov 16 2022, 7:21 PM
marcin planned changes to this revision.Nov 17 2022, 2:56 AM
marcin requested review of this revision.Nov 17 2022, 8:22 AM
atul accepted this revision.Nov 17 2022, 11:42 AM

Super clean!

This revision is now accepted and ready to land.Nov 17 2022, 11:42 AM
tomek accepted this revision.Nov 18 2022, 3:27 AM
marcin updated this revision to Diff 18685.Nov 21 2022, 9:32 AM

Rebase master

Harbormaster completed remote builds in B13638: Diff 18685.Nov 21 2022, 9:46 AM
marcin updated this revision to Diff 18754.Nov 23 2022, 4:50 AM

Rebase before landing

Harbormaster completed remote builds in B13688: Diff 18754.Nov 23 2022, 5:03 AM
Closed by commit rCOMM22edb962ced2: Bring drafts and related actions to redux (authored by marcin). · Explain WhyNov 23 2022, 5:51 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM22edb962ced2: Bring drafts and related actions to redux.

Revision Contents
Changeset List

PathSize
lib/
types/
17 lines
native/
redux/
1 line
2 lines
web/
redux/
2 lines

Diff 18464

View Options

lib/types/redux-types.js

Loading...
View Options

native/redux/redux-setup.js

Loading...
View Options

native/redux/state-types.js

Loading...
View Options

web/redux/redux-setup.js

Loading...