Page MenuHomePhabricator
Differential D5643

Introduce drafts related types and redux actions
ClosedPublic
Actions

Authored by marcin on Nov 16 2022, 4:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 3, 12:38 AM
Unknown Object (File)
Tue, Apr 1, 7:57 AM
Unknown Object (File)
Tue, Mar 18, 4:41 AM
Unknown Object (File)
Mon, Mar 17, 7:58 PM
Unknown Object (File)
Sun, Mar 16, 9:55 AM
Unknown Object (File)
Sun, Mar 16, 9:55 AM
Unknown Object (File)
Sun, Mar 16, 9:55 AM
Unknown Object (File)
Sun, Mar 16, 9:55 AM
View All Files
Subscribers
• abosh
ashoat

Details

Reviewers
tomek
atul
ashoat
Commits
rCOMMf79c282ad8ee: Introduce drafts related types and redux actions
Summary

This differential defines types to store drafts in redux and actions to alter them via reducers. Note: setDraftStoreDraftsActionType si define temporarily to increase readability and enhance smooth code review process for this stack. It will be deleted shortly.

Test Plan

Make sure eslint and flow do not point any errors.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.Nov 16 2022, 4:27 AM
Herald added subscribers: • abosh, ashoat. · View Herald TranscriptNov 16 2022, 4:27 AM
marcin added a child revision: D5644: Bring drafts and related actions to redux.Nov 16 2022, 4:30 AM
Harbormaster completed remote builds in B13463: Diff 18462.Nov 16 2022, 4:40 AM
marcin requested review of this revision.Nov 16 2022, 4:40 AM
marcin added a comment.Nov 16 2022, 5:14 AM

Important:

Note: setDraftStoreDraftsActionType is defined temporarily to increase readability and enhance smooth code review process for this stack. It will be deleted shortly.

It will be deleted in a differential to get rid of setMessageStoreMessagesActionType and setThreadStoreActionType.

ashoat requested changes to this revision.Nov 16 2022, 7:19 PM

Since the DraftStore should not exist on web, let's keep these files in native

This revision now requires changes to proceed.Nov 16 2022, 7:19 PM
ashoat resigned from this revision.Nov 16 2022, 7:21 PM

Although maybe we want to add this on web? It didn't exist there before, but now that we have redux-persist on web maybe it is a good idea...

This revision now requires review to proceed.Nov 16 2022, 7:21 PM
marcin planned changes to this revision.Nov 17 2022, 2:56 AM
marcin requested review of this revision.Nov 17 2022, 8:22 AM
atul accepted this revision.Nov 17 2022, 11:35 AM

Looks great!

This revision is now accepted and ready to land.Nov 17 2022, 11:35 AM
tomek accepted this revision.Nov 18 2022, 3:25 AM
marcin updated this revision to Diff 18642.Nov 21 2022, 3:32 AM

Add remove all drafts store operation

Harbormaster completed remote builds in B13612: Diff 18642.Nov 21 2022, 3:46 AM
marcin updated this revision to Diff 18684.Nov 21 2022, 9:31 AM

Rebase master

Harbormaster completed remote builds in B13637: Diff 18684.Nov 21 2022, 9:46 AM
marcin updated this revision to Diff 18753.Nov 23 2022, 4:49 AM

Rebase before landing

Harbormaster completed remote builds in B13687: Diff 18753.Nov 23 2022, 5:00 AM
Closed by commit rCOMMf79c282ad8ee: Introduce drafts related types and redux actions (authored by marcin). · Explain WhyNov 23 2022, 5:51 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMf79c282ad8ee: Introduce drafts related types and redux actions.

Revision Contents
Changeset List

PathSize
lib/
actions/
7 lines
types/
25 lines

Diff 18761

View Options

lib/actions/draft-actions.js

Show All 21 Lines
a { a {
text-decoration: none; text-decoration: none;
color: #2a5db0; color: #2a5db0;
} }
img, img,
iframe { iframe {
display: block; display: block;
} }
input[type='text'], input[type='text'],
input[type='password'], input[type='password'],
textarea { textarea {
atulUnsubmitted
Not Done
Inline Actions

Moving the global input styling and moving it to the input component.

Then why are we keeping styles like border and border-radius?

Don't these styles also affect the <textarea> tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for input and another for textarea)?

atul: > Moving the global input styling and moving it to the input component. Then why are we…
benschacAuthorUnsubmitted
Done
Inline Actions

Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect textarea elements.

benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
-webkit-appearance: none;
-moz-appearance: none;
-webkit-border-radius: 0;
border: 1px solid #dddddd; border: 1px solid #dddddd;
border-radius: 1px; border-radius: 1px;
font-family: var(--font-stack); font-family: var(--font-stack);
} }
:global(#react-root) { :global(#react-root) {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
height: 100%; height: 100%;
▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines
View Options

lib/types/draft-types.js

Show All 21 Lines
a { a {
text-decoration: none; text-decoration: none;
color: #2a5db0; color: #2a5db0;
} }
img, img,
iframe { iframe {
display: block; display: block;
} }
input[type='text'], input[type='text'],
input[type='password'], input[type='password'],
textarea { textarea {
atulUnsubmitted
Not Done
Inline Actions

Moving the global input styling and moving it to the input component.

Then why are we keeping styles like border and border-radius?

Don't these styles also affect the <textarea> tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for input and another for textarea)?

atul: > Moving the global input styling and moving it to the input component. Then why are we…
benschacAuthorUnsubmitted
Done
Inline Actions

Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect textarea elements.

benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
-webkit-appearance: none;
-moz-appearance: none;
-webkit-border-radius: 0;
border: 1px solid #dddddd; border: 1px solid #dddddd;
border-radius: 1px; border-radius: 1px;
font-family: var(--font-stack); font-family: var(--font-stack);
} }
:global(#react-root) { :global(#react-root) {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
height: 100%; height: 100%;
▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines