Page MenuHomePhabricator
Differential D5710

Adjust reducers to new redux action
ClosedPublic
Actions

Authored by marcin on Nov 23 2022, 6:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 5, 1:56 AM
Unknown Object (File)
Sat, Mar 29, 6:18 AM
Unknown Object (File)
Sun, Mar 23, 12:49 PM
Unknown Object (File)
Sun, Mar 16, 9:54 AM
Unknown Object (File)
Sun, Mar 16, 9:54 AM
Unknown Object (File)
Sun, Mar 16, 9:54 AM
Unknown Object (File)
Sun, Mar 16, 9:54 AM
Unknown Object (File)
Sun, Mar 16, 9:54 AM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
atul
Commits
rCOMM0c02463f12f3: Adjust reducers to new redux action
Summary

Adjust reducers to new redux action

Test Plan
  1. Make sure eslint and flow do not complain.
  2. In SQLiteContextProvider component, just after add code that dispatches new redux action just before other actions (SET_X_STORE) are dispatched. Observe in flipper that diffs in redux state resulting from subsequent SET_X_STORE actions are empty.
  3. Log out. Start the app. Observe in flipper that diff resulting from SET_CLIENT_DB_STORE is empty.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.Nov 23 2022, 6:32 AM
Herald added a subscriber: ashoat. · View Herald TranscriptNov 23 2022, 6:32 AM
marcin added a parent revision: D5709: Move Store Loaded to redux.Nov 23 2022, 6:33 AM
marcin edited the test plan for this revision. (Show Details)Nov 23 2022, 6:37 AM
marcin added a child revision: D5711: Use new redux action and storeLoaded field.
Harbormaster completed remote builds in B13698: Diff 18777.Nov 23 2022, 6:45 AM
marcin requested review of this revision.Nov 23 2022, 6:45 AM
tomek accepted this revision.Nov 23 2022, 9:47 AM
tomek added inline comments.
lib/reducers/message-reducer.test.js
275 ↗(On Diff #18777)

What is the reason for this change?

This revision is now accepted and ready to land.Nov 23 2022, 9:47 AM
tomek added a comment.Nov 23 2022, 9:48 AM

I think the test plan should be a lot more extensive.

marcin updated this revision to Diff 18837.Nov 25 2022, 4:51 AM

Remove unnecessary [] change

Harbormaster completed remote builds in B13752: Diff 18837.Nov 25 2022, 5:04 AM
ashoat added inline comments.Nov 27 2022, 7:14 PM
native/redux/redux-setup.js
372 ↗(On Diff #18837)

Typo

marcin updated this revision to Diff 18856.EditedNov 28 2022, 2:22 AM

Fix typo

Harbormaster completed remote builds in B13771: Diff 18856.Nov 28 2022, 2:35 AM
marcin edited the test plan for this revision. (Show Details)Nov 28 2022, 5:43 AM
In D5710#170224, @tomek wrote:

I think the test plan should be a lot more extensive.

Updated in diff description

marcin updated this revision to Diff 18867.Nov 28 2022, 6:17 AM

Rebase before landing

Harbormaster completed remote builds in B13781: Diff 18867.Nov 28 2022, 6:30 AM
Closed by commit rCOMM0c02463f12f3: Adjust reducers to new redux action (authored by marcin). · Explain WhyNov 28 2022, 7:14 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM0c02463f12f3: Adjust reducers to new redux action.

Revision Contents
Changeset List

PathSize
lib/
reducers/
6 lines
6 lines
11 lines
6 lines
native/
redux/
21 lines

Diff 18875

View Options

lib/reducers/draft-reducer.js

Show All 21 Lines
a { a {
text-decoration: none; text-decoration: none;
color: #2a5db0; color: #2a5db0;
} }
img, img,
iframe { iframe {
display: block; display: block;
} }
input[type='text'], input[type='text'],
input[type='password'], input[type='password'],
textarea { textarea {
atulUnsubmitted
Not Done
Inline Actions

Moving the global input styling and moving it to the input component.

Then why are we keeping styles like border and border-radius?

Don't these styles also affect the <textarea> tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for input and another for textarea)?

atul: > Moving the global input styling and moving it to the input component. Then why are we…
benschacAuthorUnsubmitted
Done
Inline Actions

Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect textarea elements.

benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
-webkit-appearance: none;
-moz-appearance: none;
-webkit-border-radius: 0;
border: 1px solid #dddddd; border: 1px solid #dddddd;
border-radius: 1px; border-radius: 1px;
font-family: var(--font-stack); font-family: var(--font-stack);
} }
:global(#react-root) { :global(#react-root) {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
height: 100%; height: 100%;
▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines
View Options

lib/reducers/message-reducer.js

Show All 21 Lines
a { a {
text-decoration: none; text-decoration: none;
color: #2a5db0; color: #2a5db0;
} }
img, img,
iframe { iframe {
display: block; display: block;
} }
input[type='text'], input[type='text'],
input[type='password'], input[type='password'],
textarea { textarea {
atulUnsubmitted
Not Done
Inline Actions

Moving the global input styling and moving it to the input component.

Then why are we keeping styles like border and border-radius?

Don't these styles also affect the <textarea> tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for input and another for textarea)?

atul: > Moving the global input styling and moving it to the input component. Then why are we…
benschacAuthorUnsubmitted
Done
Inline Actions

Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect textarea elements.

benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
-webkit-appearance: none;
-moz-appearance: none;
-webkit-border-radius: 0;
border: 1px solid #dddddd; border: 1px solid #dddddd;
border-radius: 1px; border-radius: 1px;
font-family: var(--font-stack); font-family: var(--font-stack);
} }
:global(#react-root) { :global(#react-root) {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
height: 100%; height: 100%;
▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines
View Options

lib/reducers/message-reducer.test.js

Show All 21 Lines
a { a {
text-decoration: none; text-decoration: none;
color: #2a5db0; color: #2a5db0;
} }
img, img,
iframe { iframe {
display: block; display: block;
} }
input[type='text'], input[type='text'],
input[type='password'], input[type='password'],
textarea { textarea {
atulUnsubmitted
Not Done
Inline Actions

Moving the global input styling and moving it to the input component.

Then why are we keeping styles like border and border-radius?

Don't these styles also affect the <textarea> tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for input and another for textarea)?

atul: > Moving the global input styling and moving it to the input component. Then why are we…
benschacAuthorUnsubmitted
Done
Inline Actions

Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect textarea elements.

benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
-webkit-appearance: none;
-moz-appearance: none;
-webkit-border-radius: 0;
border: 1px solid #dddddd; border: 1px solid #dddddd;
border-radius: 1px; border-radius: 1px;
font-family: var(--font-stack); font-family: var(--font-stack);
} }
:global(#react-root) { :global(#react-root) {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
height: 100%; height: 100%;
▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines
View Options

lib/reducers/thread-reducer.js

Show All 21 Lines
a { a {
text-decoration: none; text-decoration: none;
color: #2a5db0; color: #2a5db0;
} }
img, img,
iframe { iframe {
display: block; display: block;
} }
input[type='text'], input[type='text'],
input[type='password'], input[type='password'],
textarea { textarea {
atulUnsubmitted
Not Done
Inline Actions

Moving the global input styling and moving it to the input component.

Then why are we keeping styles like border and border-radius?

Don't these styles also affect the <textarea> tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for input and another for textarea)?

atul: > Moving the global input styling and moving it to the input component. Then why are we…
benschacAuthorUnsubmitted
Done
Inline Actions

Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect textarea elements.

benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
-webkit-appearance: none;
-moz-appearance: none;
-webkit-border-radius: 0;
border: 1px solid #dddddd; border: 1px solid #dddddd;
border-radius: 1px; border-radius: 1px;
font-family: var(--font-stack); font-family: var(--font-stack);
} }
:global(#react-root) { :global(#react-root) {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
height: 100%; height: 100%;
▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines
View Options

native/redux/redux-setup.js

Loading...