Page MenuHomePhabricator

Adjust reducers to new redux action
ClosedPublic

Authored by marcin on Nov 23 2022, 6:32 AM.
Tags
None
Referenced Files
F3360609: D5710.diff
Sun, Nov 24, 1:37 PM
Unknown Object (File)
Tue, Nov 19, 2:23 PM
Unknown Object (File)
Tue, Nov 19, 2:23 PM
Unknown Object (File)
Tue, Nov 19, 2:23 PM
Unknown Object (File)
Tue, Nov 19, 2:23 PM
Unknown Object (File)
Tue, Nov 19, 2:23 PM
Unknown Object (File)
Tue, Nov 19, 2:21 PM
Unknown Object (File)
Tue, Nov 19, 2:11 PM
Subscribers

Details

Summary

Adjust reducers to new redux action

Test Plan
  1. Make sure eslint and flow do not complain.
  2. In SQLiteContextProvider component, just after add code that dispatches new redux action just before other actions (SET_X_STORE) are dispatched. Observe in flipper that diffs in redux state resulting from subsequent SET_X_STORE actions are empty.
  3. Log out. Start the app. Observe in flipper that diff resulting from SET_CLIENT_DB_STORE is empty.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek added inline comments.
lib/reducers/message-reducer.test.js
275 ↗(On Diff #18777)

What is the reason for this change?

This revision is now accepted and ready to land.Nov 23 2022, 9:47 AM

I think the test plan should be a lot more extensive.

Remove unnecessary [] change

native/redux/redux-setup.js
372 ↗(On Diff #18837)

Typo

In D5710#170224, @tomek wrote:

I think the test plan should be a lot more extensive.

Updated in diff description

This revision was automatically updated to reflect the committed changes.